From: David Wei <dw@davidwei.uk>
To: Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Keith Busch <kbusch@meta.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH] nvme: module parameter to disable pi checks
Date: Wed, 23 Oct 2024 14:21:46 -0700 [thread overview]
Message-ID: <3e97f4e9-e657-42f4-aaa0-a7200bedfe03@davidwei.uk> (raw)
In-Reply-To: <Zxla500xnmoKVrpB@kbusch-mbp>
On 2024-10-23 13:21, Keith Busch wrote:
> On Wed, Oct 23, 2024 at 08:01:43PM +0000, Chaitanya Kulkarni wrote:
>> @@ -1774,9 +1773,9 @@ static bool nvme_init_integrity(struct
>> nvme_ns_head *head,
>> return nvme_ns_has_pi(head);
>>
>> if (disable_pi)
>> - pi_type = 0;
>> + goto out;
>
> I'm not against 'goto' in principle, but I try to restrict it to
> unwinding an error, and this isn't an error. I know, personal preference
> and all...
Agreed. This is more unreadable and a modern compiler will most likely
do the right thing anyway.
next prev parent reply other threads:[~2024-10-23 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241023162331epcas5p17398e6453b275a480ace5ae5a0176001@epcas5p1.samsung.com>
2024-10-23 15:50 ` [PATCH] nvme: module parameter to disable pi checks Keith Busch
2024-10-23 20:01 ` Chaitanya Kulkarni
2024-10-23 20:21 ` Keith Busch
2024-10-23 21:21 ` David Wei [this message]
2024-10-24 1:33 ` Tokunori Ikegami
2024-10-24 5:02 ` Christoph Hellwig
2024-10-24 15:23 ` Keith Busch
2024-10-24 6:10 ` Kanchan Joshi
2024-10-24 15:19 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e97f4e9-e657-42f4-aaa0-a7200bedfe03@davidwei.uk \
--to=dw@davidwei.uk \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox