From: Keith Busch <kbusch@meta.com>
To: <linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
<linux-scsi@vger.kernel.org>, <io-uring@vger.kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>, <hch@lst.de>,
<joshi.k@samsung.com>, <javier.gonz@samsung.com>,
<bvanassche@acm.org>, Keith Busch <kbusch@kernel.org>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCHv9 1/7] block: use generic u16 for write hints
Date: Fri, 25 Oct 2024 14:36:39 -0700 [thread overview]
Message-ID: <20241025213645.3464331-2-kbusch@meta.com> (raw)
In-Reply-To: <20241025213645.3464331-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
This is still backwards compatible with lifetime hints. It just doesn't
constrain the hints to that definition.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
include/linux/blk-mq.h | 3 +--
include/linux/blk_types.h | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 59e9adf815a49..bf007a4081d9b 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -8,7 +8,6 @@
#include <linux/scatterlist.h>
#include <linux/prefetch.h>
#include <linux/srcu.h>
-#include <linux/rw_hint.h>
struct blk_mq_tags;
struct blk_flush_queue;
@@ -156,7 +155,7 @@ struct request {
struct blk_crypto_keyslot *crypt_keyslot;
#endif
- enum rw_hint write_hint;
+ unsigned short write_hint;
unsigned short ioprio;
enum mq_rq_state state;
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index dce7615c35e7e..6737795220e18 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -10,7 +10,6 @@
#include <linux/bvec.h>
#include <linux/device.h>
#include <linux/ktime.h>
-#include <linux/rw_hint.h>
struct bio_set;
struct bio;
@@ -219,7 +218,7 @@ struct bio {
*/
unsigned short bi_flags; /* BIO_* below */
unsigned short bi_ioprio;
- enum rw_hint bi_write_hint;
+ unsigned short bi_write_hint;
blk_status_t bi_status;
atomic_t __bi_remaining;
--
2.43.5
next prev parent reply other threads:[~2024-10-25 21:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 21:36 [PATCHv9 0/7] write hints with nvme fdp, scsi streams Keith Busch
2024-10-25 21:36 ` Keith Busch [this message]
2024-10-28 18:19 ` [PATCHv9 1/7] block: use generic u16 for write hints Bart Van Assche
2024-10-28 18:38 ` Keith Busch
2024-10-25 21:36 ` [PATCHv9 2/7] block: introduce max_write_hints queue limit Keith Busch
2024-10-28 11:51 ` Christoph Hellwig
2024-10-28 11:52 ` Christoph Hellwig
2024-10-25 21:36 ` [PATCHv9 3/7] block: allow ability to limit partition write hints Keith Busch
2024-10-28 11:58 ` Christoph Hellwig
2024-10-28 14:49 ` Keith Busch
2024-10-28 14:40 ` Kanchan Joshi
2024-10-28 18:27 ` Bart Van Assche
2024-10-28 19:46 ` Keith Busch
2024-10-25 21:36 ` [PATCHv9 4/7] block, fs: add write hint to kiocb Keith Busch
2024-10-28 11:59 ` Christoph Hellwig
2024-10-28 14:38 ` Keith Busch
2024-10-28 16:08 ` Christoph Hellwig
2024-10-25 21:36 ` [PATCHv9 5/7] io_uring: enable per-io hinting capability Keith Busch
2024-10-29 12:46 ` Anuj gupta
2024-10-25 21:36 ` [PATCHv9 6/7] nvme: enable FDP support Keith Busch
2024-10-25 21:36 ` [PATCHv9 7/7] scsi: set permanent stream count in block limits Keith Busch
2024-10-28 16:13 ` Bart Van Assche
2024-10-29 7:10 ` Hannes Reinecke
2024-10-28 11:49 ` [PATCHv9 0/7] write hints with nvme fdp, scsi streams Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025213645.3464331-2-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox