public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Kanchan Joshi <joshi.k@samsung.com>
To: Keith Busch <kbusch@meta.com>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-scsi@vger.kernel.org, io-uring@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, hch@lst.de,
	javier.gonz@samsung.com, bvanassche@acm.org,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv9 3/7] block: allow ability to limit partition write hints
Date: Mon, 28 Oct 2024 20:10:02 +0530	[thread overview]
Message-ID: <45c046df-e940-47d0-bb29-f3aaeb28b458@samsung.com> (raw)
In-Reply-To: <20241025213645.3464331-4-kbusch@meta.com>

On 10/26/2024 3:06 AM, Keith Busch wrote:
> +static ssize_t part_write_hint_mask_store(struct device *dev,
> +					  struct device_attribute *attr,
> +					  const char *buf, size_t count)
> +{
> +	struct block_device *bdev = dev_to_bdev(dev);
> +	unsigned short max_write_hints = bdev_max_write_hints(bdev);
> +	unsigned long *new_mask;
> +	int size;
> +
> +	if (!max_write_hints)
> +		return count;
> +
> +	size = BITS_TO_LONGS(max_write_hints) * sizeof(long);
> +	new_mask = kzalloc(size, GFP_KERNEL);
> +	if (!new_mask)
> +		return -ENOMEM;
> +
> +	bitmap_parse(buf, count, new_mask, max_write_hints);
> +	bitmap_copy(bdev->write_hint_mask, new_mask, max_write_hints);

kfree(new_mask) here.



  parent reply	other threads:[~2024-10-28 15:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 21:36 [PATCHv9 0/7] write hints with nvme fdp, scsi streams Keith Busch
2024-10-25 21:36 ` [PATCHv9 1/7] block: use generic u16 for write hints Keith Busch
2024-10-28 18:19   ` Bart Van Assche
2024-10-28 18:38     ` Keith Busch
2024-10-25 21:36 ` [PATCHv9 2/7] block: introduce max_write_hints queue limit Keith Busch
2024-10-28 11:51   ` Christoph Hellwig
2024-10-28 11:52     ` Christoph Hellwig
2024-10-25 21:36 ` [PATCHv9 3/7] block: allow ability to limit partition write hints Keith Busch
2024-10-28 11:58   ` Christoph Hellwig
2024-10-28 14:49     ` Keith Busch
2024-10-28 14:40   ` Kanchan Joshi [this message]
2024-10-28 18:27   ` Bart Van Assche
2024-10-28 19:46     ` Keith Busch
2024-10-25 21:36 ` [PATCHv9 4/7] block, fs: add write hint to kiocb Keith Busch
2024-10-28 11:59   ` Christoph Hellwig
2024-10-28 14:38     ` Keith Busch
2024-10-28 16:08       ` Christoph Hellwig
2024-10-25 21:36 ` [PATCHv9 5/7] io_uring: enable per-io hinting capability Keith Busch
2024-10-29 12:46   ` Anuj gupta
2024-10-25 21:36 ` [PATCHv9 6/7] nvme: enable FDP support Keith Busch
2024-10-25 21:36 ` [PATCHv9 7/7] scsi: set permanent stream count in block limits Keith Busch
2024-10-28 16:13   ` Bart Van Assche
2024-10-29  7:10   ` Hannes Reinecke
2024-10-28 11:49 ` [PATCHv9 0/7] write hints with nvme fdp, scsi streams Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45c046df-e940-47d0-bb29-f3aaeb28b458@samsung.com \
    --to=joshi.k@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=javier.gonz@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox