From: Guixin Liu <kanie@linux.alibaba.com>
To: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
kch@nvidia.com
Cc: linux-nvme@lists.infradead.org
Subject: [PATCH RFC 3/3] nvmet: report ns's vwc not present
Date: Mon, 4 Nov 2024 16:55:02 +0800 [thread overview]
Message-ID: <20241104085524.118221-4-kanie@linux.alibaba.com> (raw)
In-Reply-To: <20241104085524.118221-1-kanie@linux.alibaba.com>
Currently, we report that controller has vwc even though the ns may
not have vwc. Report ns's vwc not present when not buffered_io or
backdev doesn't have vwc.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
drivers/nvme/target/admin-cmd.c | 36 +++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 081f0473cd9e..dffb84f560ad 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -685,6 +685,39 @@ static void nvmet_execute_identify_ctrl_nvm(struct nvmet_req *req)
nvmet_zero_sgl(req, 0, sizeof(struct nvme_id_ctrl_nvm)));
}
+static void nvmet_execute_identify_cs_indep(struct nvmet_req *req)
+{
+ struct nvme_id_ns_cs_indep *id;
+ u16 status;
+
+ status = nvmet_req_find_ns(req);
+ if (status)
+ goto out;
+
+ id = kzalloc(sizeof(*id), GFP_KERNEL);
+ if (!id) {
+ status = NVME_SC_INTERNAL;
+ goto out;
+ }
+
+ if ((req->ns->file && !req->ns->buffered_io) ||
+ (req->ns->bdev && !bdev_write_cache(req->ns->bdev)))
+ id->nsfeat |= NVME_NS_VWC_NOT_PRESENT;
+
+ id->nmic |= NVME_NS_NMIC_SHARED;
+ ///TODO: report reservation supported when that patch applied.
+ id->anagrpid = cpu_to_le32(req->ns->anagrpid);
+
+ if (req->ns->readonly)
+ id->nsattr |= NVME_NS_ATTR_RO;
+ id->nstat = NVME_NSTAT_NRDY;
+
+ status = nvmet_copy_to_sgl(req, 0, id, sizeof(*id));
+ kfree(id);
+out:
+ nvmet_req_complete(req, status);
+}
+
static void nvmet_execute_identify(struct nvmet_req *req)
{
if (!nvmet_check_transfer_len(req, NVME_IDENTIFY_DATA_SIZE))
@@ -729,6 +762,9 @@ static void nvmet_execute_identify(struct nvmet_req *req)
break;
}
break;
+ case NVME_ID_CNS_NS_CS_INDEP:
+ nvmet_execute_identify_cs_indep(req);
+ return;
}
pr_debug("unhandled identify cns %d on qid %d\n",
--
2.43.0
prev parent reply other threads:[~2024-11-04 8:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 8:54 [PATCH RFC 0/3] set nvme ns's vwc respectively Guixin Liu
2024-11-04 8:55 ` [PATCH RFC 1/3] nvme: check ns's volatile write cache not present Guixin Liu
2024-11-05 11:12 ` Christoph Hellwig
2024-11-04 8:55 ` [PATCH RFC 2/3] nvme: query independent identify ns by default Guixin Liu
2024-11-05 11:11 ` Christoph Hellwig
2024-11-05 20:03 ` Keith Busch
2024-11-06 1:52 ` Guixin Liu
2024-11-04 8:55 ` Guixin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104085524.118221-4-kanie@linux.alibaba.com \
--to=kanie@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox