Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Guixin Liu <kanie@linux.alibaba.com>
To: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, sagi@grimberg.me, kch@nvidia.com,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH RFC 2/3] nvme: query independent identify ns by default
Date: Wed, 6 Nov 2024 09:52:23 +0800	[thread overview]
Message-ID: <5af7ec6b-9534-4a19-be58-d64f68a3472f@linux.alibaba.com> (raw)
In-Reply-To: <Zyp6K5XER535YZRt@kbusch-mbp.dhcp.thefacebook.com>


在 2024/11/6 04:03, Keith Busch 写道:
> On Tue, Nov 05, 2024 at 12:11:06PM +0100, Christoph Hellwig wrote:
>> On Mon, Nov 04, 2024 at 04:55:01PM +0800, Guixin Liu wrote:
>>> Query independent identify ns by default, if returning fail,
>>> go back to sending the "identify namespace data structure for the
>>> specified NSID or the namespace capabilities for the NVM Command
>>> Set(cns = 0)".
>> How is this related to the rest of the series?
> Patch 3 provides target support for the VWCNP flag, but the host driver
> wouldn't check it without this patch. I'm assuming that's why this patch
> is included here: so both sides can be tested.
Yes.
> But if you have the time to review a different patchset, I would prefer
> we get nvmet up to 2.1 compliance and restrict this identification to
> 2.0 and above where it's required.

Yeah sure, I see the Matias's patchset too, you could apply my number 
one patch

first, when the nvmet's version increased to 2.1 and Matia's patchset 
applied,

I will continue to working on nvme target's ns respective vwcnp.

Best Regards,

Guixin Liu



  reply	other threads:[~2024-11-06  1:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04  8:54 [PATCH RFC 0/3] set nvme ns's vwc respectively Guixin Liu
2024-11-04  8:55 ` [PATCH RFC 1/3] nvme: check ns's volatile write cache not present Guixin Liu
2024-11-05 11:12   ` Christoph Hellwig
2024-11-04  8:55 ` [PATCH RFC 2/3] nvme: query independent identify ns by default Guixin Liu
2024-11-05 11:11   ` Christoph Hellwig
2024-11-05 20:03     ` Keith Busch
2024-11-06  1:52       ` Guixin Liu [this message]
2024-11-04  8:55 ` [PATCH RFC 3/3] nvmet: report ns's vwc not present Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5af7ec6b-9534-4a19-be58-d64f68a3472f@linux.alibaba.com \
    --to=kanie@linux.alibaba.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox