[PATCH] nvmet: fix the error of point math issue

[PATCH] nvmet: fix the error of point math issue

[Guixin Liu]

Fix the wrong place of parenthesis of ctrl_eds and data point in
nvmet_execute_pr_report(), switch to "void *" first and then do
the addtion.

Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
 drivers/nvme/target/pr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/target/pr.c b/drivers/nvme/target/pr.c
index bef82135a0e7..550effcfb9ad 100644
--- a/drivers/nvme/target/pr.c
+++ b/drivers/nvme/target/pr.c
@@ -848,8 +848,8 @@ static void nvmet_execute_pr_report(struct nvmet_req *req)
 		/*
 		 * continue to get the number of all registrans.
 		 */
-		if ((void *)(ctrl_eds + sizeof(*ctrl_eds)) >
-			(void *)(data + num_bytes))
+		if (((void *)ctrl_eds + sizeof(*ctrl_eds)) >
+		    ((void *)data + num_bytes))
 			continue;
 		/*
 		 * Dynamic controller, set cntlid to 0xffff.
-- 
2.43.0

Re: [PATCH] nvmet: fix the error of point math issue

[Dan Carpenter]

On Mon, Nov 11, 2024 at 06:40:35PM +0800, Guixin Liu wrote:
> Fix the wrong place of parenthesis of ctrl_eds and data point in
> nvmet_execute_pr_report(), switch to "void *" first and then do
> the addtion.
> 
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>

This needs a Fixes tag so that the stable tools know not to apply it to old
kernels.

regards,
dan carpenter

Re: [PATCH] nvmet: fix the error of point math issue

[Christoph Hellwig]

On Mon, Nov 11, 2024 at 01:48:57PM +0300, Dan Carpenter wrote:
> On Mon, Nov 11, 2024 at 06:40:35PM +0800, Guixin Liu wrote:
> > Fix the wrong place of parenthesis of ctrl_eds and data point in
> > nvmet_execute_pr_report(), switch to "void *" first and then do
> > the addtion.
> > 
> > Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> 
> This needs a Fixes tag so that the stable tools know not to apply it to old
> kernels.

We might still be able to fold it in as it's near the top of the
nvme tree not send upstream yet.

Re: [PATCH] nvmet: fix the error of point math issue

[Keith Busch]

On Mon, Nov 11, 2024 at 06:40:35PM +0800, Guixin Liu wrote:
> Fix the wrong place of parenthesis of ctrl_eds and data point in
> nvmet_execute_pr_report(), switch to "void *" first and then do
> the addtion.

Thanks, I folded this inot the original commit.

Re: [PATCH] nvmet: fix the error of point math issue

[Guixin Liu]

在 2024/11/12 01:54, Keith Busch 写道:
> On Mon, Nov 11, 2024 at 06:40:35PM +0800, Guixin Liu wrote:
>> Fix the wrong place of parenthesis of ctrl_eds and data point in
>> nvmet_execute_pr_report(), switch to "void *" first and then do
>> the addtion.
> Thanks, I folded this inot the original commit.

Thanks to fold that.

Best Regards,

Guixin Liu