From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 2/2] nvme-pci: use sgls for all user requests if possible
Date: Wed, 13 Nov 2024 05:58:59 +0100 [thread overview]
Message-ID: <20241113045859.GC20379@lst.de> (raw)
In-Reply-To: <20241112210620.2650523-3-kbusch@meta.com>
On Tue, Nov 12, 2024 at 01:06:20PM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> If the device supports SGLs, use these for all user requests. This
> format encodes the expected transfer length so it can catch short buffer
> errors in a user command, whether it occurred accidently or maliciously.
>
> For controllers that support SGL data mode, this is a viable mitigation
> to CVE-2023-6238.
The patch itself looks fine, but instead of the handwaivy mitigation,
maybe just disable passthrough without SGL support by default to actually
fix and not just mitigate the CVE?
next prev parent reply other threads:[~2024-11-13 4:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 21:06 [PATCHv2 0/2] Using SGLs for userspace commands Keith Busch
2024-11-12 21:06 ` [PATCHv2 1/2] nvme-pci: add support for sgl metadata Keith Busch
2024-11-13 4:58 ` Christoph Hellwig
2024-11-13 15:48 ` Keith Busch
2024-11-12 21:06 ` [PATCHv2 2/2] nvme-pci: use sgls for all user requests if possible Keith Busch
2024-11-13 4:58 ` Christoph Hellwig [this message]
2024-11-13 15:48 ` Keith Busch
2024-11-14 5:56 ` Christoph Hellwig
2024-11-14 15:53 ` Keith Busch
2024-11-14 16:42 ` Christoph Hellwig
2024-11-14 17:29 ` Keith Busch
2024-11-13 4:50 ` [PATCHv2 0/2] Using SGLs for userspace commands Christoph Hellwig
2024-11-13 15:50 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113045859.GC20379@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox