From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCHv2 2/2] nvme-pci: use sgls for all user requests if possible
Date: Thu, 14 Nov 2024 10:29:48 -0700 [thread overview]
Message-ID: <ZzYzjFBr2WH5rvjN@kbusch-mbp> (raw)
In-Reply-To: <20241114164245.GA4132@lst.de>
On Thu, Nov 14, 2024 at 05:42:45PM +0100, Christoph Hellwig wrote:
> On Thu, Nov 14, 2024 at 08:53:49AM -0700, Keith Busch wrote:
> > Only admin users can access this path by default. You have to opt-in for
> > it, so it's not exploitable unless you ask for it.
>
> We do allow non-privileged users to send I/O commands and a small
> whitelist of admin commands by default, limited by the CSE effects.
Not if you can't open the device. The default access permissions don't
allow non-priviledged users.
> > I can't see disabling
> > the interface entirely. In a previous version of this patch, I had the
> > kernel tainted if you tried to do passthrough without SGL support. Would
> > that be a fair compromise if I reintroduce that behavior?
>
> Taint might be a bit too strong, but a one-time message in the log might
> be useful.
Sounds good to me.
next prev parent reply other threads:[~2024-11-14 17:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 21:06 [PATCHv2 0/2] Using SGLs for userspace commands Keith Busch
2024-11-12 21:06 ` [PATCHv2 1/2] nvme-pci: add support for sgl metadata Keith Busch
2024-11-13 4:58 ` Christoph Hellwig
2024-11-13 15:48 ` Keith Busch
2024-11-12 21:06 ` [PATCHv2 2/2] nvme-pci: use sgls for all user requests if possible Keith Busch
2024-11-13 4:58 ` Christoph Hellwig
2024-11-13 15:48 ` Keith Busch
2024-11-14 5:56 ` Christoph Hellwig
2024-11-14 15:53 ` Keith Busch
2024-11-14 16:42 ` Christoph Hellwig
2024-11-14 17:29 ` Keith Busch [this message]
2024-11-13 4:50 ` [PATCHv2 0/2] Using SGLs for userspace commands Christoph Hellwig
2024-11-13 15:50 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzYzjFBr2WH5rvjN@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox