* [PATCH] nvme-pci: define pr_fmt()
@ 2024-12-09 9:49 Baruch Siach
2024-12-12 6:22 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2024-12-09 9:49 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: linux-nvme, Baruch Siach
Make pr_err() call from nvme_find_rq() produce messages with prefix, to
ease debug.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
drivers/nvme/host/pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index ff91000b5cf0..049ec18c037a 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -4,6 +4,7 @@
* Copyright (c) 2011-2014, Intel Corporation.
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/acpi.h>
#include <linux/async.h>
#include <linux/blkdev.h>
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme-pci: define pr_fmt()
2024-12-09 9:49 [PATCH] nvme-pci: define pr_fmt() Baruch Siach
@ 2024-12-12 6:22 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2024-12-12 6:22 UTC (permalink / raw)
To: Baruch Siach
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme
On Mon, Dec 09, 2024 at 11:49:28AM +0200, Baruch Siach wrote:
> Make pr_err() call from nvme_find_rq() produce messages with prefix, to
> ease debug.
Really? If you want useful information there I don't think the prefix
is very useful. You'd be better off passing the nvme_ctrl and then
use dev_err based on that.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-12 6:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-09 9:49 [PATCH] nvme-pci: define pr_fmt() Baruch Siach
2024-12-12 6:22 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox