* [PATCH v2] nvmet: propagate npwg topology
@ 2024-12-18 2:33 Luis Chamberlain
2024-12-24 10:43 ` Sagi Grimberg
2024-12-27 21:21 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Luis Chamberlain @ 2024-12-18 2:33 UTC (permalink / raw)
To: hch, sagi, kch; +Cc: linux-nvme, gost.dev, mcgrof
Ensure we propagate npwg to the target as well instead
of assuming its the same logical blocks per physical block.
This ensures devices with large IUs information properly
propagated on the target.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
On this v2: I just drop the awupf stuff for later work.
drivers/nvme/target/io-cmd-bdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index 0bda83d0fc3e..eaf31c823cbe 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -36,7 +36,7 @@ void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id)
*/
id->nsfeat |= 1 << 4;
/* NPWG = Namespace Preferred Write Granularity. 0's based */
- id->npwg = lpp0b;
+ id->npwg = to0based(bdev_io_min(bdev) / bdev_logical_block_size(bdev));
/* NPWA = Namespace Preferred Write Alignment. 0's based */
id->npwa = id->npwg;
/* NPDG = Namespace Preferred Deallocate Granularity. 0's based */
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] nvmet: propagate npwg topology
2024-12-18 2:33 [PATCH v2] nvmet: propagate npwg topology Luis Chamberlain
@ 2024-12-24 10:43 ` Sagi Grimberg
2024-12-27 21:21 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2024-12-24 10:43 UTC (permalink / raw)
To: Luis Chamberlain, hch, kch; +Cc: linux-nvme, gost.dev
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] nvmet: propagate npwg topology
2024-12-18 2:33 [PATCH v2] nvmet: propagate npwg topology Luis Chamberlain
2024-12-24 10:43 ` Sagi Grimberg
@ 2024-12-27 21:21 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2024-12-27 21:21 UTC (permalink / raw)
To: Luis Chamberlain; +Cc: hch, sagi, kch, linux-nvme, gost.dev
On Tue, Dec 17, 2024 at 06:33:25PM -0800, Luis Chamberlain wrote:
> Ensure we propagate npwg to the target as well instead
> of assuming its the same logical blocks per physical block.
>
> This ensures devices with large IUs information properly
> propagated on the target.
Thanks, applied to nvme-6.13.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-27 21:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-18 2:33 [PATCH v2] nvmet: propagate npwg topology Luis Chamberlain
2024-12-24 10:43 ` Sagi Grimberg
2024-12-27 21:21 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox