* [PATCH] nvme: make nvme_tls_attrs_group static
@ 2025-01-28 15:25 Keith Busch
2025-01-28 15:27 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Keith Busch @ 2025-01-28 15:25 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, sagi, hare, Keith Busch
From: Keith Busch <kbusch@kernel.org>
To suppress the compiler "warning: symbol 'nvme_tls_attrs_group' was not
declared. Should it be static?"
Fixes:
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index b68a9e5f1ea39..3a41b9ab0f13c 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -792,7 +792,7 @@ static umode_t nvme_tls_attrs_are_visible(struct kobject *kobj,
return a->mode;
}
-const struct attribute_group nvme_tls_attrs_group = {
+static const struct attribute_group nvme_tls_attrs_group = {
.attrs = nvme_tls_attrs,
.is_visible = nvme_tls_attrs_are_visible,
};
--
2.43.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: make nvme_tls_attrs_group static
2025-01-28 15:25 [PATCH] nvme: make nvme_tls_attrs_group static Keith Busch
@ 2025-01-28 15:27 ` Christoph Hellwig
2025-01-28 21:46 ` Chaitanya Kulkarni
2025-01-31 8:17 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-01-28 15:27 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-nvme, hch, sagi, hare, Keith Busch
On Tue, Jan 28, 2025 at 07:25:12AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> To suppress the compiler "warning: symbol 'nvme_tls_attrs_group' was not
> declared. Should it be static?"
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: make nvme_tls_attrs_group static
2025-01-28 15:25 [PATCH] nvme: make nvme_tls_attrs_group static Keith Busch
2025-01-28 15:27 ` Christoph Hellwig
@ 2025-01-28 21:46 ` Chaitanya Kulkarni
2025-01-31 8:17 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-01-28 21:46 UTC (permalink / raw)
To: Keith Busch, linux-nvme@lists.infradead.org
Cc: hch@lst.de, sagi@grimberg.me, hare@suse.de, Keith Busch
On 1/28/25 07:25, Keith Busch wrote:
> From: Keith Busch<kbusch@kernel.org>
>
> To suppress the compiler "warning: symbol 'nvme_tls_attrs_group' was not
> declared. Should it be static?"
>
> Fixes:
> Signed-off-by: Keith Busch<kbusch@kernel.org>
> ---
Empty fixes tag, apart from that looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: make nvme_tls_attrs_group static
2025-01-28 15:25 [PATCH] nvme: make nvme_tls_attrs_group static Keith Busch
2025-01-28 15:27 ` Christoph Hellwig
2025-01-28 21:46 ` Chaitanya Kulkarni
@ 2025-01-31 8:17 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2025-01-31 8:17 UTC (permalink / raw)
To: Keith Busch, linux-nvme; +Cc: hch, hare, Keith Busch
On 28/01/2025 17:25, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> To suppress the compiler "warning: symbol 'nvme_tls_attrs_group' was not
> declared. Should it be static?"
>
> Fixes:
missing ^
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-31 8:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-28 15:25 [PATCH] nvme: make nvme_tls_attrs_group static Keith Busch
2025-01-28 15:27 ` Christoph Hellwig
2025-01-28 21:46 ` Chaitanya Kulkarni
2025-01-31 8:17 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox