From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
pmenzel@molgen.mpg.de, Keith Busch <kbusch@kernel.org>
Subject: Re: [RFC PATCH] nvme: replace lazy sgl warn with informational message
Date: Fri, 31 Jan 2025 08:48:28 +0100 [thread overview]
Message-ID: <20250131074828.GA16628@lst.de> (raw)
In-Reply-To: <20250130175131.3613423-1-kbusch@meta.com>
On Thu, Jan 30, 2025 at 09:51:31AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Instead of warning about the device's SGL capabilities the first time we
> consider using them with a passthrough command, print out what the
> device is capable of during initialization. While we're at it, print
> other interesting capabilities that may be useful to know when you just
> have a dmesg. The ouput format was inspired by other existing subsystems
> like pci.
>
> And example of the new message when used with a default qemu nvme
> emulated device:
>
> nvme nvme0: sgl+ meta-sgl+ sed- vwc+ apst- dsm+ wz+
Printing out the capabilities sounds really useful. But I don't see
how this is useful for replacing the warning about the unchecked
passthrough?
next prev parent reply other threads:[~2025-01-31 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 17:51 [RFC PATCH] nvme: replace lazy sgl warn with informational message Keith Busch
2025-01-31 7:48 ` Christoph Hellwig [this message]
2025-01-31 8:06 ` Sagi Grimberg
2025-01-31 17:54 ` Keith Busch
2025-02-03 6:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131074828.GA16628@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=pmenzel@molgen.mpg.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox