From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, pmenzel@molgen.mpg.de
Subject: Re: [RFC PATCH] nvme: replace lazy sgl warn with informational message
Date: Mon, 3 Feb 2025 07:41:46 +0100 [thread overview]
Message-ID: <20250203064146.GB16864@lst.de> (raw)
In-Reply-To: <Z50OZsVUvKQHvorh@kbusch-mbp>
On Fri, Jan 31, 2025 at 10:54:46AM -0700, Keith Busch wrote:
> I thought this patch could remove the message because it tells you
> upfront what you'll get if you use the passthrough interface. The
> existing message tells you what you're getting once you actually try to
> use it, so they felt a bit redundant.
>
> > I agree, I'd keep the warn_once messages.
>
> Okay. The problem with the message is that it's a new warn, but nothing
> has really changed as far as what the driver supports, so having it at
> the "warn" level caused some alarm. Any concern if it's an info_once
> instead? I just want to avoid repeat explanations on its implications;
> I've experienced several offlist discussions about it already.
Well, we do want to warn, right? To make sure all the current
administratative uses of passthrough switch the sysfs interfaces we
added over time.
prev parent reply other threads:[~2025-02-03 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 17:51 [RFC PATCH] nvme: replace lazy sgl warn with informational message Keith Busch
2025-01-31 7:48 ` Christoph Hellwig
2025-01-31 8:06 ` Sagi Grimberg
2025-01-31 17:54 ` Keith Busch
2025-02-03 6:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203064146.GB16864@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=pmenzel@molgen.mpg.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox