Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org,
	Lennart Poettering <lennart@poettering.net>
Subject: Re: [PATCH 1/2] nvmet: make 'readonly' setting configurable
Date: Fri, 4 Apr 2025 08:25:10 +0200	[thread overview]
Message-ID: <20250404062510.GC31468@lst.de> (raw)
In-Reply-To: <20250403144747.43043-2-hare@kernel.org>

On Thu, Apr 03, 2025 at 04:47:46PM +0200, Hannes Reinecke wrote:
> The namespace already has a 'readonly' setting, which is controlled
> by the 'write protect' feature.
> This patch introduces a namespace
> configfs attribute 'readonly' to make it settable by the admin.

Please describe the spec feature this corresponds to, and why setting
the NSATTR CWP flag without a formal write protect is fine.  From
looking at the language in the spec it probably is, but that really
needs to go into a commit log.



  parent reply	other threads:[~2025-04-04  6:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 14:47 [PATCH 0/2] nvmet: improve 'read-only' handling Hannes Reinecke
2025-04-03 14:47 ` [PATCH 1/2] nvmet: make 'readonly' setting configurable Hannes Reinecke
2025-04-03 15:44   ` Keith Busch
2025-04-03 15:51     ` Hannes Reinecke
2025-04-04  6:21     ` Christoph Hellwig
2025-04-08 14:24       ` Keith Busch
2025-04-04  6:25   ` Christoph Hellwig [this message]
2025-04-03 14:47 ` [PATCH 2/2] nvmet: implement persistent read-only namespace feature Hannes Reinecke
2025-04-04  6:26   ` Christoph Hellwig
2025-04-04  9:36     ` Hannes Reinecke
2025-04-04  6:19 ` [PATCH 0/2] nvmet: improve 'read-only' handling Christoph Hellwig
2025-04-04  6:25   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250404062510.GC31468@lst.de \
    --to=hch@lst.de \
    --cc=hare@kernel.org \
    --cc=kbusch@kernel.org \
    --cc=lennart@poettering.net \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox