From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvmet: implement persistent read-only namespace feature
Date: Fri, 4 Apr 2025 08:26:17 +0200 [thread overview]
Message-ID: <20250404062617.GD31468@lst.de> (raw)
In-Reply-To: <20250403144747.43043-3-hare@kernel.org>
On Thu, Apr 03, 2025 at 04:47:47PM +0200, Hannes Reinecke wrote:
> Per default we try to open the 'device_path' read-write, which might
> fail if the device is read-only. So retry with opening read-only, and
> implement a new 'persistent_ro' flag if we did so.
> And map that flag onto the 'Permanently Write Protect' setting in the
> write protection feature.
This sounds like a really horrible interface, but maybe there is logic
for it so explain why we don't require the explicit read-only attribute
to open read only.
next prev parent reply other threads:[~2025-04-04 6:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 14:47 [PATCH 0/2] nvmet: improve 'read-only' handling Hannes Reinecke
2025-04-03 14:47 ` [PATCH 1/2] nvmet: make 'readonly' setting configurable Hannes Reinecke
2025-04-03 15:44 ` Keith Busch
2025-04-03 15:51 ` Hannes Reinecke
2025-04-04 6:21 ` Christoph Hellwig
2025-04-08 14:24 ` Keith Busch
2025-04-04 6:25 ` Christoph Hellwig
2025-04-03 14:47 ` [PATCH 2/2] nvmet: implement persistent read-only namespace feature Hannes Reinecke
2025-04-04 6:26 ` Christoph Hellwig [this message]
2025-04-04 9:36 ` Hannes Reinecke
2025-04-04 6:19 ` [PATCH 0/2] nvmet: improve 'read-only' handling Christoph Hellwig
2025-04-04 6:25 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404062617.GD31468@lst.de \
--to=hch@lst.de \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox