* [PATCH] nvme-tcp: remove redundant check to ctrl->opts
@ 2025-04-15 6:00 Hannes Reinecke
2025-04-15 21:36 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hannes Reinecke @ 2025-04-15 6:00 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Sagi Grimberg, Keith Busch, linux-nvme, Hannes Reinecke,
Dan Carpenter
When checking for secure concatenation we have already validated
that 'ctrl->opts' is set, so we can remove this check.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Hannes Reinecke <hare@kernel.org>
---
drivers/nvme/host/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 72d260201d8c..e20a994d63c2 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2358,7 +2358,7 @@ static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new)
if (ret)
return ret;
- if (ctrl->opts && ctrl->opts->concat && !ctrl->tls_pskid) {
+ if (ctrl->opts->concat && !ctrl->tls_pskid) {
/* See comments for nvme_tcp_key_revoke_needed() */
dev_dbg(ctrl->device, "restart admin queue for secure concatenation\n");
nvme_stop_keep_alive(ctrl);
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-tcp: remove redundant check to ctrl->opts
2025-04-15 6:00 [PATCH] nvme-tcp: remove redundant check to ctrl->opts Hannes Reinecke
@ 2025-04-15 21:36 ` Sagi Grimberg
2025-04-22 6:36 ` Chaitanya Kulkarni
2025-04-22 8:00 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2025-04-15 21:36 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig; +Cc: Keith Busch, linux-nvme, Dan Carpenter
Thanks Hannes,
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-tcp: remove redundant check to ctrl->opts
2025-04-15 6:00 [PATCH] nvme-tcp: remove redundant check to ctrl->opts Hannes Reinecke
2025-04-15 21:36 ` Sagi Grimberg
@ 2025-04-22 6:36 ` Chaitanya Kulkarni
2025-04-22 8:00 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-04-22 6:36 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig
Cc: Sagi Grimberg, Keith Busch, linux-nvme@lists.infradead.org,
Dan Carpenter
On 4/14/25 23:00, Hannes Reinecke wrote:
> When checking for secure concatenation we have already validated
> that 'ctrl->opts' is set, so we can remove this check.
>
> Reported-by: Dan Carpenter<dan.carpenter@linaro.org>
> Signed-off-by: Hannes Reinecke<hare@kernel.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-tcp: remove redundant check to ctrl->opts
2025-04-15 6:00 [PATCH] nvme-tcp: remove redundant check to ctrl->opts Hannes Reinecke
2025-04-15 21:36 ` Sagi Grimberg
2025-04-22 6:36 ` Chaitanya Kulkarni
@ 2025-04-22 8:00 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-04-22 8:00 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Christoph Hellwig, Sagi Grimberg, Keith Busch, linux-nvme,
Dan Carpenter
Thanks,
applied to nvme-6.16.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-22 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-15 6:00 [PATCH] nvme-tcp: remove redundant check to ctrl->opts Hannes Reinecke
2025-04-15 21:36 ` Sagi Grimberg
2025-04-22 6:36 ` Chaitanya Kulkarni
2025-04-22 8:00 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox