From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>,
Dhankaran Singh Ajravat <dhankaran@meta.com>
Subject: Re: [PATCH] nvme-pci: fix queue unquiesce check on slot_reset
Date: Fri, 25 Apr 2025 15:19:35 +0200 [thread overview]
Message-ID: <20250425131935.GA5460@lst.de> (raw)
In-Reply-To: <20250424171801.2300390-1-kbusch@meta.com>
On Thu, Apr 24, 2025 at 10:18:01AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> A zero return means the reset was successfully scheduled. We don't want
> to unquiesce the queues while the reset_work is pending, as that will
> just flush out requeued requests to a failed completion.
>
> Fixes: 71a5bb153be104 ("nvme: ensure disabling pairs with unquiesce")
Sounds like this code path isn't get teste all the much if this stuck
around for so long..
next prev parent reply other threads:[~2025-04-25 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 17:18 [PATCH] nvme-pci: fix queue unquiesce check on slot_reset Keith Busch
2025-04-25 13:19 ` Christoph Hellwig [this message]
2025-04-25 14:33 ` Keith Busch
2025-04-28 15:22 ` Keith Busch
2025-04-29 12:13 ` Christoph Hellwig
2025-04-29 13:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425131935.GA5460@lst.de \
--to=hch@lst.de \
--cc=dhankaran@meta.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox