From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org,
Dhankaran Singh Ajravat <dhankaran@meta.com>
Subject: Re: [PATCH] nvme-pci: fix queue unquiesce check on slot_reset
Date: Tue, 29 Apr 2025 14:13:20 +0200 [thread overview]
Message-ID: <20250429121320.GA12411@lst.de> (raw)
In-Reply-To: <aA-dT-iVfnSVx_6u@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Apr 28, 2025 at 09:22:55AM -0600, Keith Busch wrote:
> > > Sounds like this code path isn't get teste all the much if this stuck
> > > around for so long..
> >
> > The conditions that trigger pcie errors were the primary concern. Of
> > course you'll get IO errors, right? The pcie connection is flakey! But
> > we are supposed retry IO's after recovery, which we weren't doing, and
> > that was a secondary concern I embaressingly overlooked for many
> > reports.
>
> We can still take this right?
Absolutely. Just wondering how this managed to slip through.
next prev parent reply other threads:[~2025-04-29 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 17:18 [PATCH] nvme-pci: fix queue unquiesce check on slot_reset Keith Busch
2025-04-25 13:19 ` Christoph Hellwig
2025-04-25 14:33 ` Keith Busch
2025-04-28 15:22 ` Keith Busch
2025-04-29 12:13 ` Christoph Hellwig [this message]
2025-04-29 13:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429121320.GA12411@lst.de \
--to=hch@lst.de \
--cc=dhankaran@meta.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox