Re: [PATCH 5/7] nvme-pci: use a better encoding for small prp pool allocations

[Leon Romanovsky <leon@kernel.org>]

On Tue, May 13, 2025 at 09:00:21AM +0200, Christoph Hellwig wrote:
> Add a separate flag to encode that the transfer is using the small
> page sized pool, and use a normal 0..n count for the number of
> descriptors.
> 
> Contains improvements and suggestions from Kanchan Joshi
> <joshi.k@samsung.com> and Leon Romanovsky <leonro@nvidia.com>.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/nvme/host/pci.c | 82 ++++++++++++++++++++---------------------
>  1 file changed, 39 insertions(+), 43 deletions(-)

<...>

> -static void nvme_free_prps(struct nvme_queue *nvmeq, struct request *req)
> +static inline struct dma_pool *nvme_dma_pool(struct nvme_queue *nvmeq,
> +		struct nvme_iod *iod)
> +{

You probably want __always_inline and not inline here.


> +	if (iod->flags & IOD_SMALL_DESCRIPTOR)
> +		return nvmeq->descriptor_pools.small;
> +	return nvmeq->descriptor_pools.large;
> +}

Thanks,
Reviewed-by: Leon Romanovsky <leon@kernel.org>