From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi/Kanchan Joshi <joshi.k@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Caleb Sander Mateos <csander@purestorage.com>,
Leon Romanovsky <leon@kernel.org>,
linux-nvme@lists.infradead.org,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH 2/7] nvme-pci: store aborted state in flags variable
Date: Wed, 14 May 2025 07:06:45 +0200 [thread overview]
Message-ID: <20250514050645.GC24101@lst.de> (raw)
In-Reply-To: <c6e9b2bb-6e32-43da-8a8a-29775c21c853@samsung.com>
On Tue, May 13, 2025 at 07:43:43PM +0530, Kanchan Joshi/Kanchan Joshi wrote:
> On 5/13/2025 12:30 PM, Christoph Hellwig wrote:
> > From: Leon Romanovsky<leon@kernel.org>
> >
> > Instead of keeping dedicated "bool aborted" variable, let's reuse
> > newly introduced flags variable and save space.
>
> Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
>
> Nit: I would not call it 'reuse' as flags (within iod) did not exist
> before this patch.
It was when Leon wrote the patch, but my patch reshuffling changed that.
I'll fix it up to match the reality.
next prev parent reply other threads:[~2025-05-14 5:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 7:00 misc cleanups for nvme-pci Christoph Hellwig
2025-05-13 7:00 ` [PATCH 1/7] nvme-pci: don't try to use SGLs for metadata on the admin queue Christoph Hellwig
2025-05-13 7:28 ` Leon Romanovsky
2025-05-13 7:39 ` Christoph Hellwig
2025-05-13 7:45 ` Leon Romanovsky
2025-05-13 7:47 ` Christoph Hellwig
2025-05-13 7:51 ` Leon Romanovsky
2025-05-13 7:00 ` [PATCH 2/7] nvme-pci: store aborted state in flags variable Christoph Hellwig
2025-05-13 14:13 ` Kanchan Joshi/Kanchan Joshi
2025-05-14 0:44 ` Caleb Sander Mateos
2025-05-14 5:06 ` Christoph Hellwig [this message]
2025-05-13 7:00 ` [PATCH 3/7] nvme-pci: remove struct nvme_descriptor Christoph Hellwig
2025-05-13 14:15 ` Kanchan Joshi/Kanchan Joshi
2025-05-14 1:07 ` Caleb Sander Mateos
2025-05-14 5:15 ` Christoph Hellwig
2025-05-13 7:00 ` [PATCH 4/7] nvme-pci: rename the descriptor pools Christoph Hellwig
2025-05-13 7:35 ` Leon Romanovsky
2025-05-13 14:16 ` Kanchan Joshi/Kanchan Joshi
2025-05-14 1:03 ` Caleb Sander Mateos
2025-05-13 7:00 ` [PATCH 5/7] nvme-pci: use a better encoding for small prp pool allocations Christoph Hellwig
2025-05-13 7:39 ` Leon Romanovsky
2025-05-13 7:40 ` Christoph Hellwig
2025-05-13 7:49 ` Leon Romanovsky
2025-05-13 14:49 ` Kanchan Joshi/Kanchan Joshi
2025-05-13 15:06 ` Keith Busch
2025-05-14 5:12 ` Christoph Hellwig
2025-05-14 13:06 ` Keith Busch
2025-05-14 14:00 ` Christoph Hellwig
2025-05-14 17:48 ` Caleb Sander Mateos
2025-05-14 17:47 ` Caleb Sander Mateos
2025-05-13 7:00 ` [PATCH 6/7] nvme-pci: add a symolic name for the small pool size Christoph Hellwig
2025-05-13 14:51 ` Kanchan Joshi/Kanchan Joshi
2025-05-14 18:24 ` Caleb Sander Mateos
2025-05-13 7:00 ` [PATCH 7/7] nvme-pci: use struct_size for allocation struct nvme_dev Christoph Hellwig
2025-05-13 7:20 ` Leon Romanovsky
2025-05-13 14:54 ` Kanchan Joshi/Kanchan Joshi
2025-05-14 18:28 ` Caleb Sander Mateos
2025-05-13 15:34 ` misc cleanups for nvme-pci Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514050645.GC24101@lst.de \
--to=hch@lst.de \
--cc=csander@purestorage.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox