From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH] nvme: fix command limits status code
Date: Wed, 21 May 2025 08:14:00 +0200 [thread overview]
Message-ID: <20250521061400.GA3539@lst.de> (raw)
In-Reply-To: <20250520202037.2751433-1-kbusch@meta.com>
On Tue, May 20, 2025 at 01:20:37PM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The command specific status code, 0x183, was introduced in nvme 2.0
> specification defined to "Command Size Limits Exceeded" and only ever
> applied to DSM and Copy commands.
Yeah, that's weird. Chaitanya, did you implement this off an early
draft?
> Fix the name and remove the incorrect
> special handling for it.
Where the incorrect handling is the mappings in nvme_error_status
and nvme_status_to_pr_err? Yes, limit exceed should not be a not
supported, so this looks fine. But it would be good to actually
spell that out in the commit message. I'll fix it up if you don't
object.
next prev parent reply other threads:[~2025-05-21 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 20:20 [PATCH] nvme: fix command limits status code Keith Busch
2025-05-21 1:46 ` Chaitanya Kulkarni
2025-05-21 6:14 ` Christoph Hellwig [this message]
2025-05-21 14:24 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521061400.GA3539@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox