From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH] nvme: fix command limits status code
Date: Wed, 21 May 2025 08:24:56 -0600 [thread overview]
Message-ID: <aC3iOCSN8kcJ8MAp@kbusch-mbp> (raw)
In-Reply-To: <20250521061400.GA3539@lst.de>
On Wed, May 21, 2025 at 08:14:00AM +0200, Christoph Hellwig wrote:
> On Tue, May 20, 2025 at 01:20:37PM -0700, Keith Busch wrote:
>
> > Fix the name and remove the incorrect
> > special handling for it.
>
> Where the incorrect handling is the mappings in nvme_error_status
> and nvme_status_to_pr_err? Yes, limit exceed should not be a not
> supported, so this looks fine. But it would be good to actually
> spell that out in the commit message. I'll fix it up if you don't
> object.
Yes, those two error mappings on the host side, and the target side use
of the misnamed status code too.
prev parent reply other threads:[~2025-05-21 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 20:20 [PATCH] nvme: fix command limits status code Keith Busch
2025-05-21 1:46 ` Chaitanya Kulkarni
2025-05-21 6:14 ` Christoph Hellwig
2025-05-21 14:24 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC3iOCSN8kcJ8MAp@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox