From: Nilay Shroff <nilay@linux.ibm.com>
To: linux-nvme@lists.infradead.org
Cc: wagi@kernel.org, martinus.gpy@gmail.com
Subject: [PATCH 2/2] nvme: add iopolicy field in JSON output
Date: Mon, 12 Jan 2026 16:46:01 +0530 [thread overview]
Message-ID: <20260112111731.1631091-3-nilay@linux.ibm.com> (raw)
In-Reply-To: <20260112111731.1631091-1-nilay@linux.ibm.com>
Commit d0b4c6cf0006 (“nvme: extend show-topology command to add
support for multipath”) extended the show-topology command output
and added the iopolicy field to the subsystem header in the text
output even when show-topology command is executed in non-verbose
mode.
However, the iopolicy field was not included in the JSON output,
(for non-verbose output) resulting in an inconsistency between the
text and JSON formats. This change fixes that by adding the iopolicy
field to the JSON output when the show-topology command is executed
with the JSON output format.
Fixes: d0b4c6cf0006 ("nvme: extend show-topology command to add support for multipath")
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
nvme-print-json.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/nvme-print-json.c b/nvme-print-json.c
index ca5d77483..72d17ca60 100644
--- a/nvme-print-json.c
+++ b/nvme-print-json.c
@@ -4851,6 +4851,8 @@ static void json_simple_topology(struct nvme_global_ctx *ctx)
subsystem_attrs = json_create_object();
obj_add_str(subsystem_attrs, "Name", nvme_subsystem_get_name(s));
obj_add_str(subsystem_attrs, "NQN", nvme_subsystem_get_nqn(s));
+ obj_add_str(subsystem_attrs, "IOPolicy",
+ nvme_subsystem_get_iopolicy(s));
if (verbose_mode()) {
obj_add_str(subsystem_attrs, "Model",
@@ -4859,8 +4861,6 @@ static void json_simple_topology(struct nvme_global_ctx *ctx)
nvme_subsystem_get_serial(s));
obj_add_str(subsystem_attrs, "Firmware",
nvme_subsystem_get_fw_rev(s));
- obj_add_str(subsystem_attrs, "IOPolicy",
- nvme_subsystem_get_iopolicy(s));
obj_add_str(subsystem_attrs, "Type",
nvme_subsystem_get_type(s));
}
--
2.52.0
next prev parent reply other threads:[~2026-01-12 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 11:15 [PATCH 0/2] nvme-cli: limit printing iopolicy in subsystem header Nilay Shroff
2026-01-12 11:16 ` [PATCH 1/2] nvme: avoid printing iopolicy in list-subsys output Nilay Shroff
2026-01-12 23:47 ` Chaitanya Kulkarni
2026-01-13 7:29 ` Martin George
2026-01-12 11:16 ` Nilay Shroff [this message]
2026-01-12 23:47 ` [PATCH 2/2] nvme: add iopolicy field in JSON output Chaitanya Kulkarni
2026-01-13 7:31 ` Martin George
2026-01-14 9:37 ` [PATCH 0/2] nvme-cli: limit printing iopolicy in subsystem header Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112111731.1631091-3-nilay@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martinus.gpy@gmail.com \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox