Re: [PATCH 1/2] nvme: avoid printing iopolicy in list-subsys output

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 1/12/26 03:16, Nilay Shroff wrote:
> Since commit d0b4c6cf0006 (“nvme: extend show-topology command to add
> support for multipath”), the subsystem header printed by both show-
> topology and list-subsys includes the iopolicy field regardless of
> whether the verbose flag is specified.
>
> For show-topology, this behavior is intentional and useful. The command
> now prints additional columns such as Nodes or queue-depth depending on
> the configured I/O policy, and displaying the iopolicy value makes it
> easier to correlate the output with the active policy configured for
> the subsystem.
>
> However, the same iopolicy field is also printed in the list-subsys
> output, where it is not always relevant. This happens because both
> commands share the common helper stdout_subsys_config() to print the
> subsystem header.
>
> This change fixes the inconsistency by always printing the iopolicy
> field for show-topology, while suppressing it for list-subsys unless
> the command is invoked with the verbose flag.
>
> Fixes: d0b4c6cf0006 ("nvme: extend show-topology command to add support for multipath")
> Signed-off-by: Nilay Shroff<nilay@linux.ibm.com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck