From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@arkamax.eu>
Cc: Christoph Hellwig <hch@lst.de>,
Maurizio Lombardi <mlombard@redhat.com>,
kbusch@kernel.org, mheyne@amazon.de, emilne@redhat.com,
jmeneghi@redhat.com, linux-nvme@lists.infradead.org,
dwagner@suse.de, mkhalfella@purestorage.com,
chaitanyak@nvidia.com, hare@kernel.org
Subject: Re: [PATCH V4 6/9] nvme: use per controller timeout waits over depending on global default
Date: Mon, 11 May 2026 14:32:11 +0200 [thread overview]
Message-ID: <20260511123211.GB17601@lst.de> (raw)
In-Reply-To: <DIFTJU624OOA.3TZPJSC4SF1CC@arkamax.eu>
On Mon, May 11, 2026 at 01:42:47PM +0200, Maurizio Lombardi wrote:
> On Mon May 11, 2026 at 10:10 AM CEST, Christoph Hellwig wrote:
> > On Fri, May 08, 2026 at 03:33:32PM +0200, Maurizio Lombardi wrote:
> >> Instead of passing NVME_IO_TIMEOUT as a parameter with every call to
> >> nvme_wait_freeze_timeout, use the controller's preferred timeout.
> >
> > This should probably go very early in the series before even adding
> > configurable timeouts as it just drops a pointless paramter.
>
> It drops the parameter but uses the timeout value stored in
> ctrl->io_timeout, so it actually depends on the patch introducing
> the per-controller io_timeout.
Well, switch to hardcoded NVME_IO_TIMEOUT early, and then replace it
with the variable timeout like the other instances of NVME_IO_TIMEOUT.
>
> Maurizio
---end quoted text---
next prev parent reply other threads:[~2026-05-11 12:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 13:33 [PATCH V4 0/9] nvme: Refactor and expose per-controller timeout configuration Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 1/9] nvme: Let the blocklayer set timeouts for requests Maurizio Lombardi
2026-05-11 9:37 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 2/9] nvme: add sysfs attribute to change admin timeout per nvme controller Maurizio Lombardi
2026-05-08 16:57 ` Daniel Wagner
2026-05-10 22:10 ` Sagi Grimberg
2026-05-11 8:07 ` Christoph Hellwig
2026-05-11 11:29 ` Maurizio Lombardi
2026-05-11 12:31 ` Christoph Hellwig
2026-05-11 9:46 ` Hannes Reinecke
2026-05-11 10:05 ` Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 3/9] nvme: fix race condition between connected uevent and STARTED_ONCE flag Maurizio Lombardi
2026-05-08 16:57 ` Daniel Wagner
2026-05-10 22:10 ` Sagi Grimberg
2026-05-11 8:07 ` Christoph Hellwig
2026-05-11 12:54 ` Sagi Grimberg
2026-05-11 15:09 ` Keith Busch
2026-05-11 15:45 ` Maurizio Lombardi
2026-05-11 17:10 ` Keith Busch
2026-05-11 8:08 ` Christoph Hellwig
2026-05-11 9:47 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 4/9] nvme: pci: use admin queue timeout over NVME_ADMIN_TIMEOUT Maurizio Lombardi
2026-05-10 22:10 ` Sagi Grimberg
2026-05-11 8:08 ` Christoph Hellwig
2026-05-11 9:48 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 5/9] nvme: add sysfs attribute to change IO timeout per controller Maurizio Lombardi
2026-05-08 17:08 ` Daniel Wagner
2026-05-10 22:12 ` Sagi Grimberg
2026-05-11 8:52 ` Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 6/9] nvme: use per controller timeout waits over depending on global default Maurizio Lombardi
2026-05-11 8:10 ` Christoph Hellwig
2026-05-11 11:42 ` Maurizio Lombardi
2026-05-11 12:32 ` Christoph Hellwig [this message]
2026-05-11 9:50 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 7/9] nvme-core: align fabrics_q teardown with admin_q in nvme_free_ctrl Maurizio Lombardi
2026-05-10 22:15 ` Sagi Grimberg
2026-05-11 8:11 ` Christoph Hellwig
2026-05-11 9:53 ` Hannes Reinecke
2026-05-11 9:57 ` Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 8/9] nvmet-loop: do not alloc admin tag set during reset Maurizio Lombardi
2026-05-08 17:09 ` Daniel Wagner
2026-05-10 22:16 ` Sagi Grimberg
2026-05-11 8:12 ` Christoph Hellwig
2026-05-11 9:55 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 9/9] nvme-core: warn on allocating admin tag set with existing queue Maurizio Lombardi
2026-05-10 22:16 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511123211.GB17601@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mheyne@amazon.de \
--cc=mkhalfella@purestorage.com \
--cc=mlombard@arkamax.eu \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox