From: Christoph Hellwig <hch@lst.de>
To: Chao Shi <coshi036@gmail.com>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Jens Axboe <axboe@kernel.dk>,
Tatsuya Sasaki <tatsuya6.sasaki@kioxia.com>,
Maurizio Lombardi <mlombard@arkamax.eu>,
linux-kernel@vger.kernel.org, Sungwoo Kim <iam@sung-woo.kim>,
Dave Tian <daveti@purdue.edu>, Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH v2] nvme: reserve a keep-alive admin tag for all transports
Date: Tue, 19 May 2026 09:14:48 +0200 [thread overview]
Message-ID: <20260519071448.GA9841@lst.de> (raw)
In-Reply-To: <20260515071248.2689513-1-coshi036@gmail.com>
On Fri, May 15, 2026 at 03:12:48AM -0400, Chao Shi wrote:
> A quirk-based approach was considered but no PCIe controller
> documented to declare KAS != 0 was found (two enterprise SSDs tested
> locally report KAS=0), so an allowlist has no entries today.
Quirking for spec allowed behavior sounds odd. If we care about
testing KA for PCIe it should be trivial to implement in nvmet-epf
in the kernel, but I'm not sure there is much of a point in that.
> Reproducer (run as root on an unpatched kernel with a PCIe NVMe device):
Can you wire this up as a testcase in blktests?
The patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-05-19 7:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 7:12 [PATCH v2] nvme: reserve a keep-alive admin tag for all transports Chao Shi
2026-05-19 7:14 ` Christoph Hellwig [this message]
2026-05-20 20:26 ` Keith Busch
2026-05-21 8:25 ` Christoph Hellwig
2026-05-21 14:38 ` Keith Busch
2026-05-22 12:14 ` Christoph Hellwig
2026-05-22 15:32 ` Chao S
2026-05-22 15:33 ` Chao S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519071448.GA9841@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=coshi036@gmail.com \
--cc=daveti@purdue.edu \
--cc=iam@sung-woo.kim \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@arkamax.eu \
--cc=sagi@grimberg.me \
--cc=tatsuya6.sasaki@kioxia.com \
--cc=weizhu@fiu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox