From: Christoph Hellwig <hch@lst.de>
To: liuxixin <gliuxen@gmail.com>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org,
axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] nvme: fix FDP configuration log parsing
Date: Wed, 27 May 2026 15:32:05 +0200 [thread overview]
Message-ID: <20260527133205.GA12042@lst.de> (raw)
In-Reply-To: <a989258938de2d1fb01e70fd5ea2e50185cc6899.1779848573.git.gliuxen@gmail.com>
On Wed, May 27, 2026 at 10:29:45AM +0800, liuxixin wrote:
> <cover.1779848573.git.gliuxen@gmail.com>
> From: liuxixin <gliuxen@gmail.com>
> Date: Wed, 27 May 2026 10:22:32 +0800
> Subject: [PATCH v2 1/1] nvme: fix FDP configuration log parsing
>
> The fdpcidx bounds check sets n = NUMFDPC + 1 but used > instead of >=,
> incorrectly accepting fdp_idx when it equals n (i.e. NUMFDPC + 1).
Looks good.
>
> Also validate descriptor sizes while walking the list so dsze == 0 or a
> descriptor past the log end cannot cause unbounded iteration or reads past
> the buffer.
Also looks good, although I would have split that into a separate
patch.
> Fixes: 30b5f20bb2ddab013035399e5c7e6577da49320a ("nvme: register fdp parameters with the block layer")
Please shorten the sha id to 12 characters, i.e:
Fixes: 30b5f20bb2dd ("nvme: register fdp parameters with the block layer")
next prev parent reply other threads:[~2026-05-27 13:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 7:52 [PATCH v1 1/1] nvme: fix FDP configuration log parsing liuxixin
2026-05-26 14:41 ` Keith Busch
2026-05-27 2:22 ` [PATCH v2 0/1] " liuxixin
2026-05-27 2:29 ` [PATCH v2 1/1] " liuxixin
2026-05-27 8:53 ` Nitesh Shetty
2026-05-27 13:32 ` Christoph Hellwig [this message]
2026-05-28 1:01 ` [PATCH v3 0/2] " liuxixin
2026-05-28 1:43 ` [PATCH v3 1/2] nvme: fix FDP fdpcidx bounds check liuxixin
2026-05-28 8:30 ` Christoph Hellwig
2026-05-28 1:43 ` [PATCH v3 2/2] nvme: validate FDP configuration descriptor sizes liuxixin
2026-05-28 8:30 ` Christoph Hellwig
2026-05-28 10:00 ` [PATCH v4 0/2] nvme: fix FDP configuration log parsing liuxixin
2026-05-28 10:00 ` [PATCH v4 1/2] nvme: fix FDP fdpcidx bounds check liuxixin
2026-06-02 12:27 ` Keith Busch
2026-05-28 10:00 ` [PATCH v4 2/2] nvme: validate FDP configuration descriptor sizes liuxixin
2026-06-02 12:19 ` Keith Busch
2026-06-02 14:00 ` [PATCH v5 0/1] " liuxixin
2026-06-02 14:00 ` [PATCH v5 1/1] " liuxixin
2026-06-03 9:42 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527133205.GA12042@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gliuxen@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox