Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: liuxixin <gliuxen@gmail.com>
To: linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/1] nvme: fix FDP configuration log parsing
Date: Wed, 27 May 2026 10:22:53 +0800	[thread overview]
Message-ID: <cover.1779848573.git.gliuxen@gmail.com> (raw)
In-Reply-To: <ahWw_09BJkQi9zQe@kbusch-mbp>

Hi Keith,

Thanks for the review. v2 uses the minimal bounds fix you suggested:
keep n = NUMFDPC + 1 and compare with >= instead of >.

The descriptor walk validation (dsze == 0 / past end of log) is unchanged
from v1.

## Test plan
- Build: make M=drivers/nvme -j12 (linux-next, verified)

- Repro/validation (lab):
  Tested on linux-next 7.1.0-rc4-next-20260521 with QEMU 8.2 nvme-subsys,fdp=on.
  With a single FDP configuration (NUMFDPC field 0), forcing fdpcidx=1 triggers
  FDP invalid config descriptor list on the unfixed driver, while the fix
  rejects it early with FDP index:1 out of range:1 and skips stream
  registration.

Thanks,
liuxixin



  reply	other threads:[~2026-05-27  2:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  7:52 [PATCH v1 1/1] nvme: fix FDP configuration log parsing liuxixin
2026-05-26 14:41 ` Keith Busch
2026-05-27  2:22   ` liuxixin [this message]
2026-05-27  2:29     ` [PATCH v2 " liuxixin
2026-05-27  8:53       ` Nitesh Shetty
2026-05-27 13:32       ` Christoph Hellwig
2026-05-28  1:01         ` [PATCH v3 0/2] " liuxixin
2026-05-28  1:43           ` [PATCH v3 1/2] nvme: fix FDP fdpcidx bounds check liuxixin
2026-05-28  8:30             ` Christoph Hellwig
2026-05-28  1:43           ` [PATCH v3 2/2] nvme: validate FDP configuration descriptor sizes liuxixin
2026-05-28  8:30             ` Christoph Hellwig
2026-05-28 10:00           ` [PATCH v4 0/2] nvme: fix FDP configuration log parsing liuxixin
2026-05-28 10:00             ` [PATCH v4 1/2] nvme: fix FDP fdpcidx bounds check liuxixin
2026-06-02 12:27               ` Keith Busch
2026-05-28 10:00             ` [PATCH v4 2/2] nvme: validate FDP configuration descriptor sizes liuxixin
2026-06-02 12:19               ` Keith Busch
2026-06-02 14:00                 ` [PATCH v5 0/1] " liuxixin
2026-06-02 14:00                   ` [PATCH v5 1/1] " liuxixin
2026-06-03  9:42                     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1779848573.git.gliuxen@gmail.com \
    --to=gliuxen@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox