* [PATCH] nvmetcli: store DHCHAP attributes
@ 2026-07-13 10:46 Hannes Reinecke
2026-07-13 12:16 ` Daniel Wagner
0 siblings, 1 reply; 3+ messages in thread
From: Hannes Reinecke @ 2026-07-13 10:46 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Daniel Wagner, linux-nvme, Sagi Grimberg, Keith Busch,
Hannes Reinecke
From: Hannes Reinecke <hare@suse.de>
The DHCHAP authentication is stored under hosts/, and are starting
with 'dhchap_'. So add a 'dhchap' attribute group for the host object
to correctly save and restore DHCHAP values.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
nvmet/nvme.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/nvmet/nvme.py b/nvmet/nvme.py
index faf1eb2..80d3953 100644
--- a/nvmet/nvme.py
+++ b/nvmet/nvme.py
@@ -1013,6 +1013,7 @@ class Host(CFSNode):
'''
super(Host, self).__init__()
+ self.attr_groups = ['dhchap']
self.nqn = nqn
self._path = "%s/hosts/%s" % (self.configfs_dir, nqn)
self._create_in_cfs(mode)
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmetcli: store DHCHAP attributes
2026-07-13 10:46 [PATCH] nvmetcli: store DHCHAP attributes Hannes Reinecke
@ 2026-07-13 12:16 ` Daniel Wagner
2026-07-13 13:44 ` Hannes Reinecke
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Wagner @ 2026-07-13 12:16 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Christoph Hellwig, Daniel Wagner, linux-nvme, Sagi Grimberg,
Keith Busch, Hannes Reinecke
Hi Hannes,
On Mon, Jul 13, 2026 at 12:46:57PM +0200, Hannes Reinecke wrote:
> From: Hannes Reinecke <hare@suse.de>
>
> The DHCHAP authentication is stored under hosts/, and are starting
> with 'dhchap_'. So add a 'dhchap' attribute group for the host object
> to correctly save and restore DHCHAP values.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> nvmet/nvme.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
> index faf1eb2..80d3953 100644
> --- a/nvmet/nvme.py
> +++ b/nvmet/nvme.py
> @@ -1013,6 +1013,7 @@ class Host(CFSNode):
> '''
> super(Host, self).__init__()
>
> + self.attr_groups = ['dhchap']
Would you mind also extend the test case?
Thanks,
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmetcli: store DHCHAP attributes
2026-07-13 12:16 ` Daniel Wagner
@ 2026-07-13 13:44 ` Hannes Reinecke
0 siblings, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2026-07-13 13:44 UTC (permalink / raw)
To: Daniel Wagner, Hannes Reinecke
Cc: Christoph Hellwig, Daniel Wagner, linux-nvme, Sagi Grimberg,
Keith Busch
On 7/13/26 2:16 PM, Daniel Wagner wrote:
> Hi Hannes,
>
> On Mon, Jul 13, 2026 at 12:46:57PM +0200, Hannes Reinecke wrote:
>> From: Hannes Reinecke <hare@suse.de>
>>
>> The DHCHAP authentication is stored under hosts/, and are starting
>> with 'dhchap_'. So add a 'dhchap' attribute group for the host object
>> to correctly save and restore DHCHAP values.
>>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>> nvmet/nvme.py | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
>> index faf1eb2..80d3953 100644
>> --- a/nvmet/nvme.py
>> +++ b/nvmet/nvme.py
>> @@ -1013,6 +1013,7 @@ class Host(CFSNode):
>> '''
>> super(Host, self).__init__()
>>
>> + self.attr_groups = ['dhchap']
>
> Would you mind also extend the test case?
>
Sure. Will be looking into it.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-13 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 10:46 [PATCH] nvmetcli: store DHCHAP attributes Hannes Reinecke
2026-07-13 12:16 ` Daniel Wagner
2026-07-13 13:44 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox