From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/4] nvmet: fix return status of RMI log page on allocation failure
Date: Wed, 29 Jul 2026 13:32:31 +0200 [thread overview]
Message-ID: <20260729113231.GA31402@lst.de> (raw)
In-Reply-To: <20260729105607.1398478-1-kanie@linux.alibaba.com>
On Wed, Jul 29, 2026 at 06:56:07PM +0800, Guixin Liu wrote:
> nvmet_execute_get_log_page_rmi() leaves 'status' holding NVME_SC_SUCCESS
> (set by the successful nvmet_req_find_ns() call) when the kzalloc() for
> the log buffer fails. It then jumps to the out label and completes the
> request with a success status, so the host is told the command succeeded
> while no data was transferred.
>
> Initialize 'status' to NVME_SC_INTERNAL, matching the smart log handler,
> so an allocation failure is reported as an internal error.
>
> Fixes: 5fd075cdaf36 ("nvmet: implement rotational media information log")
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-07-29 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 10:56 [PATCH 1/4] nvmet: fix return status of RMI log page on allocation failure Guixin Liu
2026-07-29 11:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729113231.GA31402@lst.de \
--to=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox