* [PATCH 1/4] nvmet: fix return status of RMI log page on allocation failure
@ 2026-07-29 10:56 Guixin Liu
2026-07-29 11:32 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Guixin Liu @ 2026-07-29 10:56 UTC (permalink / raw)
To: Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni, Keith Busch
Cc: linux-nvme
nvmet_execute_get_log_page_rmi() leaves 'status' holding NVME_SC_SUCCESS
(set by the successful nvmet_req_find_ns() call) when the kzalloc() for
the log buffer fails. It then jumps to the out label and completes the
request with a success status, so the host is told the command succeeded
while no data was transferred.
Initialize 'status' to NVME_SC_INTERNAL, matching the smart log handler,
so an allocation failure is reported as an internal error.
Fixes: 5fd075cdaf36 ("nvmet: implement rotational media information log")
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
drivers/nvme/target/admin-cmd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 01b799e92ae6..0b24d31f966d 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -309,8 +309,10 @@ static void nvmet_execute_get_log_page_rmi(struct nvmet_req *req)
}
log = kzalloc_obj(*log);
- if (!log)
+ if (!log) {
+ status = NVME_SC_INTERNAL;
goto out;
+ }
log->endgid = req->cmd->get_log_page.lsi;
disk = req->ns->bdev->bd_disk;
--
2.43.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/4] nvmet: fix return status of RMI log page on allocation failure
2026-07-29 10:56 [PATCH 1/4] nvmet: fix return status of RMI log page on allocation failure Guixin Liu
@ 2026-07-29 11:32 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2026-07-29 11:32 UTC (permalink / raw)
To: Guixin Liu
Cc: Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni, Keith Busch,
linux-nvme
On Wed, Jul 29, 2026 at 06:56:07PM +0800, Guixin Liu wrote:
> nvmet_execute_get_log_page_rmi() leaves 'status' holding NVME_SC_SUCCESS
> (set by the successful nvmet_req_find_ns() call) when the kzalloc() for
> the log buffer fails. It then jumps to the out label and completes the
> request with a success status, so the host is told the command succeeded
> while no data was transferred.
>
> Initialize 'status' to NVME_SC_INTERNAL, matching the smart log handler,
> so an allocation failure is reported as an internal error.
>
> Fixes: 5fd075cdaf36 ("nvmet: implement rotational media information log")
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-29 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-29 10:56 [PATCH 1/4] nvmet: fix return status of RMI log page on allocation failure Guixin Liu
2026-07-29 11:32 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox