* [PATCH] nvme-auth: update error log in nvme_auth_submit()
@ 2026-10-21 8:36 Martin George
2026-10-21 10:47 ` Hannes Reinecke
2026-10-21 22:13 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Martin George @ 2026-10-21 8:36 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, kbusch, sagi, hare, Martin George
nvme_auth_submit() issues both AUTH Send and AUTH Receive commands,
but the failure messages are hardcoded to "auth_send failed", which
can be misleading when an AUTH Receive fails. So print the correct
direction instead.
Signed-off-by: Martin George <marting@netapp.com>
---
drivers/nvme/host/auth.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index cbb38935fa22..85f005a5efd0 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -85,10 +85,12 @@ static int nvme_auth_submit(struct nvme_ctrl *ctrl, int qid,
qid == 0 ? NVME_QID_ANY : qid, flags);
if (ret > 0)
dev_warn(ctrl->device,
- "qid %d auth_send failed with status %d\n", qid, ret);
+ "qid %d auth_%s failed with status %d\n",
+ qid, auth_send ? "send" : "receive", ret);
else if (ret < 0)
dev_err(ctrl->device,
- "qid %d auth_send failed with error %d\n", qid, ret);
+ "qid %d auth_%s failed with error %d\n",
+ qid, auth_send ? "send" : "receive", ret);
return ret;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-auth: update error log in nvme_auth_submit()
2026-10-21 8:36 [PATCH] nvme-auth: update error log in nvme_auth_submit() Martin George
@ 2026-10-21 10:47 ` Hannes Reinecke
2026-10-21 22:13 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2026-10-21 10:47 UTC (permalink / raw)
To: Martin George, linux-nvme; +Cc: hch, kbusch, sagi, Martin George
On 10/21/26 10:36 AM, Martin George wrote:
> nvme_auth_submit() issues both AUTH Send and AUTH Receive commands,
> but the failure messages are hardcoded to "auth_send failed", which
> can be misleading when an AUTH Receive fails. So print the correct
> direction instead.
>
> Signed-off-by: Martin George <marting@netapp.com>
> ---
> drivers/nvme/host/auth.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
> index cbb38935fa22..85f005a5efd0 100644
> --- a/drivers/nvme/host/auth.c
> +++ b/drivers/nvme/host/auth.c
> @@ -85,10 +85,12 @@ static int nvme_auth_submit(struct nvme_ctrl *ctrl, int qid,
> qid == 0 ? NVME_QID_ANY : qid, flags);
> if (ret > 0)
> dev_warn(ctrl->device,
> - "qid %d auth_send failed with status %d\n", qid, ret);
> + "qid %d auth_%s failed with status %d\n",
> + qid, auth_send ? "send" : "receive", ret);
> else if (ret < 0)
> dev_err(ctrl->device,
> - "qid %d auth_send failed with error %d\n", qid, ret);
> + "qid %d auth_%s failed with error %d\n",
> + qid, auth_send ? "send" : "receive", ret);
> return ret;
> }
>
Reviewed-by: Hannes Reinecke <hare@kernel.org>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-auth: update error log in nvme_auth_submit()
2026-10-21 8:36 [PATCH] nvme-auth: update error log in nvme_auth_submit() Martin George
2026-10-21 10:47 ` Hannes Reinecke
@ 2026-10-21 22:13 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2026-10-21 22:13 UTC (permalink / raw)
To: Martin George; +Cc: linux-nvme, hch, sagi, hare, Martin George
On Wed, Oct 21, 2026 at 02:06:46PM +0530, Martin George wrote:
> nvme_auth_submit() issues both AUTH Send and AUTH Receive commands,
> but the failure messages are hardcoded to "auth_send failed", which
> can be misleading when an AUTH Receive fails. So print the correct
> direction instead.
Thanks, applied to nvme-7.4.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-21 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-21 8:36 [PATCH] nvme-auth: update error log in nvme_auth_submit() Martin George
2026-10-21 10:47 ` Hannes Reinecke
2026-10-21 22:13 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox