From: Christoph Hellwig <hch@lst.de>
To: Martin George <martinus.gpy@gmail.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org,
sagi@grimberg.me, Martin George <marting@netapp.com>
Subject: Re: [PATCH] nvme: add nvme_is_disc_subsys() helper
Date: Wed, 28 Oct 2026 15:58:18 +0100 [thread overview]
Message-ID: <20261028145818.GC15112@lst.de> (raw)
In-Reply-To: <20261022073144.5239-1-marting@netapp.com>
On Thu, Oct 22, 2026 at 01:01:44PM +0530, Martin George wrote:
> Mirror the target's nvmet_is_disc_subsys() with a host-side
> nvme_is_disc_subsys() helper, and use it for the open-coded
> subtype == NVME_NQN_DISC checks in the host code to help
> maintain consistency and improve code readability.
>
> And while here, fix an error message to refer to the subsystem
> rather than the controller.
Not going to NAK it, but the helper feels a bit pointless to me.
Do you have any bigger plans with it?
next prev parent reply other threads:[~2026-10-28 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 7:31 [PATCH] nvme: add nvme_is_disc_subsys() helper Martin George
2026-10-28 14:58 ` Christoph Hellwig [this message]
2026-10-28 15:34 ` Martin George
2026-10-28 15:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028145818.GC15112@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=martinus.gpy@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox