From: Christoph Hellwig <hch@lst.de>
To: Martin George <martinus.gpy@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, kbusch@kernel.org,
sagi@grimberg.me
Subject: Re: [PATCH] nvme: add nvme_is_disc_subsys() helper
Date: Wed, 28 Oct 2026 16:36:35 +0100 [thread overview]
Message-ID: <20261028153635.GB18772@lst.de> (raw)
In-Reply-To: <7652b5deb5e947f6dfc40f46e9e05db472183b8d.camel@gmail.com>
On Wed, Oct 28, 2026 at 09:04:03PM +0530, Martin George wrote:
> No bigger plans - it's just a small cleanup. Mainly two things:
>
> - Consistency with the target, which already has something similar
> - It folds the open-coded discovery subtype checks into one self-
> documenting helper for current & future use.
>
> So a minor net improvement rather than a prerequisite for anything.
Not sure a helper is more self-documenting than a field check.
I don't really care strongly, but this feels a bit like churn without
a real purpose to me.
prev parent reply other threads:[~2026-10-28 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 7:31 [PATCH] nvme: add nvme_is_disc_subsys() helper Martin George
2026-10-28 14:58 ` Christoph Hellwig
2026-10-28 15:34 ` Martin George
2026-10-28 15:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028153635.GB18772@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martinus.gpy@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox