Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] blk-mq: Wait for for hctx requests on CPU unplug
Date: Fri, 5 Apr 2019 16:23:27 -0600	[thread overview]
Message-ID: <226503cd-53ac-902c-7944-b2748407b1d3@kernel.dk> (raw)
In-Reply-To: <20190405215920.27085-1-keith.busch@intel.com>

On 4/5/19 3:59 PM, Keith Busch wrote:
> Managed interrupts can not migrate affinity when their CPUs are offline.
> If the CPU is allowed to shutdown before they're returned, commands
> dispatched to managed queues won't be able to complete through their
> irq handlers.
> 
> Introduce per-hctx reference counting so we can block the CPU dead
> notification for all allocated requests to complete if an hctx's last
> CPU is being taken offline.

What does this do to performance? We're doing a map per request...

-- 
Jens Axboe

  reply	other threads:[~2019-04-05 22:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 21:59 [PATCH] blk-mq: Wait for for hctx requests on CPU unplug Keith Busch
2019-04-05 22:23 ` Jens Axboe [this message]
2019-04-05 22:37   ` Keith Busch
2019-04-05 23:04     ` Jens Axboe
2019-04-05 23:36       ` Keith Busch
2019-04-06  9:44         ` Dongli Zhang
2019-04-06 21:27         ` Ming Lei
2019-04-07 13:55           ` Dongli Zhang
2019-04-08  9:49             ` Ming Lei
2019-04-08 15:36             ` Keith Busch
2019-04-08 15:21           ` Keith Busch
2019-04-07  7:51         ` Christoph Hellwig
2019-04-08 15:23           ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=226503cd-53ac-902c-7944-b2748407b1d3@kernel.dk \
    --to=axboe@kernel.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox