From: Nilay Shroff <nilay@linux.ibm.com>
To: Chaitanya Kulkarni <kch@nvidia.com>, linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/2] nvme-tcp: remove unused variable
Date: Thu, 9 Jan 2025 16:29:35 +0530 [thread overview]
Message-ID: <24b6834d-e66e-4a3c-9ea8-9790911673d8@linux.ibm.com> (raw)
In-Reply-To: <20250109063043.95996-2-kch@nvidia.com>
On 1/9/25 12:00 PM, Chaitanya Kulkarni wrote:
> The variable n declared in nvme_tcp_set_queue_io_cpu() was used in the
> original calculation when tcp target was created.
>
> With addtion of commit bd0f5c103101 ("nvme-tcp: Fix I/O queue cpu
> spreading for multiple controllers") now all the calculation is based
> on io_cpu and mq_map local variable is n is not, resulting in the
Maybe typo: 's/"local variable is n is not,"/", and local variable n is not used,"/g'
Otherwise looks good, please feel free to add:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2025-01-09 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 6:30 [PATCH 1/2] nvme-tcp: initialize the mq_map to NULL Chaitanya Kulkarni
2025-01-09 6:30 ` [PATCH 2/2] nvme-tcp: remove unused variable Chaitanya Kulkarni
2025-01-09 10:59 ` Nilay Shroff [this message]
2025-01-09 10:58 ` [PATCH 1/2] nvme-tcp: initialize the mq_map to NULL Nilay Shroff
2025-01-10 22:48 ` Sagi Grimberg
2025-01-11 3:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24b6834d-e66e-4a3c-9ea8-9790911673d8@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=lkp@intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox