From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, hch@lst.de,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/2] nvme-tcp: initialize the mq_map to NULL
Date: Fri, 10 Jan 2025 20:57:59 -0700 [thread overview]
Message-ID: <Z4HsR9kaAvRUQTw4@kbusch-mbp> (raw)
In-Reply-To: <271ee0a1-431e-483d-80b1-72405b0728cc@grimberg.me>
On Sat, Jan 11, 2025 at 12:48:04AM +0200, Sagi Grimberg wrote:
>
>
>
> On 09/01/2025 8:30, Chaitanya Kulkarni wrote:
> > Initialize the local variable mq_map to NULL to remove the kernel
> > test robot warning.
> >
> > drivers/nvme/host/tcp.c:1594:13: warning: variable 'mq_map' is used
> > uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
> >
> > Fixes: bd0f5c103101 ("nvme-tcp: Fix I/O queue cpu spreading for multiple controllers")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202501091328.r4kJ6xhy-lkp@intel.com/
> > Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
>
> We should probably just fold both this and the next one to the original
> patch.
Sure, folded in with an updated commit message to reflect Chaitanya's
changes.
prev parent reply other threads:[~2025-01-11 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 6:30 [PATCH 1/2] nvme-tcp: initialize the mq_map to NULL Chaitanya Kulkarni
2025-01-09 6:30 ` [PATCH 2/2] nvme-tcp: remove unused variable Chaitanya Kulkarni
2025-01-09 10:59 ` Nilay Shroff
2025-01-09 10:58 ` [PATCH 1/2] nvme-tcp: initialize the mq_map to NULL Nilay Shroff
2025-01-10 22:48 ` Sagi Grimberg
2025-01-11 3:57 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4HsR9kaAvRUQTw4@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=lkp@intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox