Re: [bug report] nvme/063 failure (tcp transport)

[Hannes Reinecke <hare@suse.de>]

On 5/16/25 14:31, Shinichiro Kawasaki wrote:
> Hello all,
> 
> Using the kernel v6.15-rc6 and the latest blktests (git hash 613b8377e4d3), I
> observe the test case nvme/063 fails with tcp transport. Kernel reported WARN in
> blk_mq_unquiesce_queue and KASAN sauf in blk_mq_queue_tag_busy_iter [1]. The
> failure is recreated in stable manner on my test nodes.
> 
> The test case script had a bug then this failure was not found until the bug get
> fixed. I tried the kernel v6.15-rc1, and observed the same failure symptom. This
> test case cannot be run with the kernel v6.14, since it does not have secure
> concatenation feature.
> 
> Actions for fix will be appreciated.
> 
Seems like we are calling 'quiesce' twice:

static void nvme_tcp_teardown_ctrl(struct nvme_ctrl *ctrl, bool shutdown)
{
	nvme_tcp_teardown_io_queues(ctrl, shutdown);
	nvme_quiesce_admin_queue(ctrl);
	nvme_disable_ctrl(ctrl, shutdown);
	nvme_tcp_teardown_admin_queue(ctrl, shutdown);
}

static void nvme_tcp_teardown_admin_queue(struct nvme_ctrl *ctrl,
		bool remove)
{
	nvme_quiesce_admin_queue(ctrl);
	blk_sync_queue(ctrl->admin_q);
	nvme_tcp_stop_queue(ctrl, 0);


I'll send a patch.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich