From: Hannes Reinecke <hare@suse.de>
To: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-rdma: fix crash for no IO queues
Date: Sat, 27 Feb 2021 10:12:43 +0100 [thread overview]
Message-ID: <2a9bb7c3-eb4e-2341-dcfa-583d41912977@suse.de> (raw)
In-Reply-To: <7c30ddb7-ee41-9972-4cb6-0a5c089f687c@huawei.com>
On 2/24/21 6:59 AM, Chao Leng wrote:
>
>
> On 2021/2/24 7:21, Keith Busch wrote:
>> On Tue, Feb 23, 2021 at 03:26:02PM +0800, Chao Leng wrote:
>>> A crash happens when set feature(NVME_FEAT_NUM_QUEUES) timeout in nvme
>>> over rdma(roce) reconnection, the reason is use the queue which is not
>>> alloced.
>>>
>>> If it is not discovery and no io queues, the connection should fail.
>>
>> If you're getting a timeout, we need to quit initialization. Hannes
>> attempted making that status visible for fabrics here:
>>
>>
>> http://lists.infradead.org/pipermail/linux-nvme/2021-January/022353.html
> I know the patch. It can not solve the scenario: target may be an
> attacker or the target behavior is incorrect.
> If target return 0 io queues or return other error code, the crash will
> still happen. We should not allow this to happen.
I'm fully with you that we shouldn't crash, but at the same time a value
of '0' for the number of I/O queues is considered valid.
So we should fix the code to handle this scenario, and not disallowing
zero I/O queues.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-27 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 7:26 [PATCH] nvme-rdma: fix crash for no IO queues Chao Leng
2021-02-23 22:03 ` Chaitanya Kulkarni
2021-02-24 5:52 ` Chao Leng
2021-02-23 23:21 ` Keith Busch
2021-02-24 5:59 ` Chao Leng
2021-02-27 9:12 ` Hannes Reinecke [this message]
2021-02-27 9:30 ` Chao Leng
2021-03-02 7:48 ` Hannes Reinecke
2021-03-02 9:49 ` Chao Leng
2021-03-02 18:24 ` Keith Busch
2021-03-03 2:27 ` Chao Leng
2021-03-03 3:14 ` Keith Busch
2021-03-03 3:39 ` Chao Leng
2021-03-03 7:41 ` Hannes Reinecke
2021-03-03 15:08 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a9bb7c3-eb4e-2341-dcfa-583d41912977@suse.de \
--to=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox