From: Chao Leng <lengchao@huawei.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme-rdma: fix crash for no IO queues
Date: Wed, 24 Feb 2021 13:52:20 +0800 [thread overview]
Message-ID: <1ac356d5-f154-699e-e929-e9f351b7da07@huawei.com> (raw)
In-Reply-To: <BYAPR04MB49657E5EB6A8F9C8C07C736386809@BYAPR04MB4965.namprd04.prod.outlook.com>
On 2021/2/24 6:03, Chaitanya Kulkarni wrote:
> On 2/22/21 23:30, Chao Leng wrote:
>> A crash happens when set feature(NVME_FEAT_NUM_QUEUES) timeout in nvme
>> over rdma(roce) reconnection, the reason is use the queue which is not
>> alloced.
>>
>> If it is not discovery and no io queues, the connection should fail.
>>
>> Signed-off-by: Chao Leng <lengchao@huawei.com>
>
> Can you please share more information about
>
> "when set feature(NVME_FEAT_NUM_QUEUES) timeout" scenario ?
Inject a large number of bit errors intermittently. This will cause
request time out, and then reconnection will trigger by error recovery.
The requests of reconnect may also time out. If set feature
(NVME_FEAT_NUM_QUEUES, which is called by nvme_set_queue_count) time out
and the reconnection may success. Block will continue send request,
and then crash due to use unallocated queue.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-24 5:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 7:26 [PATCH] nvme-rdma: fix crash for no IO queues Chao Leng
2021-02-23 22:03 ` Chaitanya Kulkarni
2021-02-24 5:52 ` Chao Leng [this message]
2021-02-23 23:21 ` Keith Busch
2021-02-24 5:59 ` Chao Leng
2021-02-27 9:12 ` Hannes Reinecke
2021-02-27 9:30 ` Chao Leng
2021-03-02 7:48 ` Hannes Reinecke
2021-03-02 9:49 ` Chao Leng
2021-03-02 18:24 ` Keith Busch
2021-03-03 2:27 ` Chao Leng
2021-03-03 3:14 ` Keith Busch
2021-03-03 3:39 ` Chao Leng
2021-03-03 7:41 ` Hannes Reinecke
2021-03-03 15:08 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ac356d5-f154-699e-e929-e9f351b7da07@huawei.com \
--to=lengchao@huawei.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox