From: Nilay Shroff <nilay@linux.ibm.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, shinichiro.kawasaki@wdc.com,
chaitanyak@nvidia.com, hch@lst.de, kbusch@kernel.org,
sagi@grimberg.me, axboe@kernel.dk, gjoyce@linux.ibm.com
Subject: Re: [PATCHv3 2/2] nvme: add test for writing to file-ns just after disabling it
Date: Fri, 6 Dec 2024 18:20:28 +0530 [thread overview]
Message-ID: <2d47ea9f-44bd-43b4-bac6-113b55f415e4@linux.ibm.com> (raw)
In-Reply-To: <8b57ae43-e01a-4b08-9eae-bba43ba2c851@flourine.local>
On 12/6/24 18:02, Daniel Wagner wrote:
> On Fri, Dec 06, 2024 at 04:48:08PM +0530, Nilay Shroff wrote:
>> + # disable target namespace and write to it
>> + echo 0 > ${ns_path}/enable
>> + nvme write --start-block=1 --block-count=0 \
>> + --data-size=512 --data="/dev/urandom" "$disk" 2>>"$FULL"
>>
> I haven't checked if this was already discussed. Just wondering what
> --block-count=0 is supposed to. Is it the 0 based thing?
>
Yes it's zero based field.
# nvme write --help
Usage: nvme write <device> [OPTIONS]
Copy from provided data buffer (default
buffer is stdin) to specified logical blocks on the given device.
Options:
[ --verbose, -v ] --- Increase output verbosity
<snip>
[ --block-count=<NUM>, -c <NUM> ] --- number of blocks (zeroes based)
on device to access
> Rest looks good. So feel free to add
>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>
next prev parent reply other threads:[~2024-12-06 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 11:18 [PATCHv3 0/2] add nvme test for creating sleep while atomic kernel BUG Nilay Shroff
2024-12-06 11:18 ` [PATCHv3 1/2] nvme/052: move nvmf_wait_for_ns() to common/nvme Nilay Shroff
2024-12-06 12:27 ` Daniel Wagner
2024-12-24 11:29 ` Sagi Grimberg
2024-12-06 11:18 ` [PATCHv3 2/2] nvme: add test for writing to file-ns just after disabling it Nilay Shroff
2024-12-06 12:32 ` Daniel Wagner
2024-12-06 12:50 ` Nilay Shroff [this message]
2024-12-24 11:29 ` Sagi Grimberg
2024-12-09 7:16 ` [PATCHv3 0/2] add nvme test for creating sleep while atomic kernel BUG Chaitanya Kulkarni
2024-12-09 11:50 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d47ea9f-44bd-43b4-bac6-113b55f415e4@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox