public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, shinichiro.kawasaki@wdc.com,
	 chaitanyak@nvidia.com, hch@lst.de, kbusch@kernel.org,
	sagi@grimberg.me, axboe@kernel.dk,  gjoyce@linux.ibm.com
Subject: Re: [PATCHv3 2/2] nvme: add test for writing to file-ns just after disabling it
Date: Fri, 6 Dec 2024 13:32:45 +0100	[thread overview]
Message-ID: <8b57ae43-e01a-4b08-9eae-bba43ba2c851@flourine.local> (raw)
In-Reply-To: <20241206111812.489140-3-nilay@linux.ibm.com>

On Fri, Dec 06, 2024 at 04:48:08PM +0530, Nilay Shroff wrote:
> +		# disable target namespace and write to it
> +		echo 0 > ${ns_path}/enable
> +		nvme write --start-block=1 --block-count=0 \
> +			--data-size=512 --data="/dev/urandom" "$disk" 2>>"$FULL"
>
I haven't checked if this was already discussed. Just wondering what
--block-count=0 is supposed to. Is it the 0 based thing?

Rest looks good. So feel free to add

Reviewed-by: Daniel Wagner <dwagner@suse.de>


  reply	other threads:[~2024-12-06 12:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 11:18 [PATCHv3 0/2] add nvme test for creating sleep while atomic kernel BUG Nilay Shroff
2024-12-06 11:18 ` [PATCHv3 1/2] nvme/052: move nvmf_wait_for_ns() to common/nvme Nilay Shroff
2024-12-06 12:27   ` Daniel Wagner
2024-12-24 11:29   ` Sagi Grimberg
2024-12-06 11:18 ` [PATCHv3 2/2] nvme: add test for writing to file-ns just after disabling it Nilay Shroff
2024-12-06 12:32   ` Daniel Wagner [this message]
2024-12-06 12:50     ` Nilay Shroff
2024-12-24 11:29   ` Sagi Grimberg
2024-12-09  7:16 ` [PATCHv3 0/2] add nvme test for creating sleep while atomic kernel BUG Chaitanya Kulkarni
2024-12-09 11:50 ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b57ae43-e01a-4b08-9eae-bba43ba2c851@flourine.local \
    --to=dwagner@suse.de \
    --cc=axboe@kernel.dk \
    --cc=chaitanyak@nvidia.com \
    --cc=gjoyce@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox