Re: [PATCH 3/4] lpfc: enable FPIN notification for NVMe

[Hannes Reinecke <hare@suse.de>]

On 4/29/25 02:30, Justin Tee wrote:
> Hi Hannes,
> 
> May we qualify the call to nvme_fc_fpin_rcv with something like this?
> 
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index cf1fbfb15c5d..ea76b4550e30 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -10251,8 +10251,11 @@ lpfc_els_rcv_fpin(struct lpfc_vport *vport,
> void *p, u32 fpin_length)
>                  if (deliver) {
>                          fc_host_fpin_rcv(lpfc_shost_from_vport(vport),
>                                           fpin_length, (char *)fpin, 0);
> -                       nvme_fc_fpin_rcv(vport->localport,
> -                                        fpin_length, (char *)fpin);
> +#if (IS_ENABLED(CONFIG_NVME_FC))
> +                       if (vport->cfg_enable_fc4_type == LPFC_ENABLE_BOTH)
> +                               nvme_fc_fpin_rcv(vport->localport,
> +                                                fpin_length, (char *)fpin);
> +#endif
>                  }
>                  desc_cnt++;
>          }
> 
That should rather be a 'cfg_enable_fc4_type & LPFC_ENABLE_NVME', right?

But okay, I'll fold it in.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich