Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Tee <justintee8345@gmail.com>
To: hare@kernel.org
Cc: Justin Tee <justin.tee@broadcom.com>,
	James Smart <jsmart2021@gmail.com>,
	 Dick Kennedy <dick.kennedy@broadcom.com>,
	Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	 Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/4] lpfc: enable FPIN notification for NVMe
Date: Mon, 28 Apr 2025 17:30:57 -0700	[thread overview]
Message-ID: <CABPRKS9yTExMW+PdJHnXiftck8dQQcF-RxVUt75M=P2bTnfmHA@mail.gmail.com> (raw)
In-Reply-To: <20250428063635.125879-4-hare@kernel.org>

Hi Hannes,

May we qualify the call to nvme_fc_fpin_rcv with something like this?

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index cf1fbfb15c5d..ea76b4550e30 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -10251,8 +10251,11 @@ lpfc_els_rcv_fpin(struct lpfc_vport *vport,
void *p, u32 fpin_length)
                if (deliver) {
                        fc_host_fpin_rcv(lpfc_shost_from_vport(vport),
                                         fpin_length, (char *)fpin, 0);
-                       nvme_fc_fpin_rcv(vport->localport,
-                                        fpin_length, (char *)fpin);
+#if (IS_ENABLED(CONFIG_NVME_FC))
+                       if (vport->cfg_enable_fc4_type == LPFC_ENABLE_BOTH)
+                               nvme_fc_fpin_rcv(vport->localport,
+                                                fpin_length, (char *)fpin);
+#endif
                }
                desc_cnt++;
        }

Regards,
Justin


  reply	other threads:[~2025-04-29  0:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28  6:36 [PATCHv3 0/4] nvme-fc: FPIN link integrity handling hare
2025-04-28  6:36 ` [PATCH 1/4] fc_els: use 'union fc_tlv_desc' hare
2025-04-29  0:32   ` Justin Tee
2025-04-29  5:56     ` Hannes Reinecke
2025-04-28  6:36 ` [PATCH 2/4] nvme-fc: marginal path handling hare
2025-04-28  6:36 ` [PATCH 3/4] lpfc: enable FPIN notification for NVMe hare
2025-04-29  0:30   ` Justin Tee [this message]
2025-04-29  6:14     ` Hannes Reinecke
2025-04-29 21:28       ` Justin Tee
2025-04-28  6:36 ` [PATCH 4/4] qla2xxx: " hare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPRKS9yTExMW+PdJHnXiftck8dQQcF-RxVUt75M=P2bTnfmHA@mail.gmail.com' \
    --to=justintee8345@gmail.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=hare@kernel.org \
    --cc=hch@lst.de \
    --cc=jsmart2021@gmail.com \
    --cc=justin.tee@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox