From: Sagi Grimberg <sagi@grimberg.me>
To: Nilay Shroff <nilay@linux.ibm.com>, linux-nvme@lists.infradead.org
Cc: dwagner@suse.de, hare@suse.com, kbusch@kernel.org, hch@lst.de,
gjoyce@linux.ibm.com, wenxiong@linux.ibm.com
Subject: Re: [PATCH 0/7] nvme-cli: add nvme top command for real-time monitoring
Date: Mon, 11 May 2026 15:54:48 +0300 [thread overview]
Message-ID: <36ef5a04-8b34-479c-bc09-09af6cd104f5@grimberg.me> (raw)
In-Reply-To: <9799c2c0-f6a0-41e6-9fa0-2993b60f1801@linux.ibm.com>
On 11/05/2026 14:59, Nilay Shroff wrote:
> On 5/11/26 4:04 AM, Sagi Grimberg wrote:
>>
>>
>> On 30/04/2026 13:52, Nilay Shroff wrote:
>>> Hi,
>>>
>>> Monitoring NVMe devices and paths in production is currently limited to
>>> static snapshots via nvme-cli. While this is sufficient for basic
>>> inspection, it is not ideal for NVMe-oF (fabrics) deployments where
>>> path
>>> conditions can change dynamically due to varying network latency,
>>> congestion, or link failures.
>>>
>>> In multipath environments, administrators often need continuous
>>> visibility into path state, ANA status, queue depth, link speed, and
>>> error counters. Today, this typically requires repeatedly invoking
>>> commands or relying on ad-hoc tooling, making it harder to quickly
>>> identify issues.
>>>
>>> This patch series introduces "nvme top", a tool for real-time
>>> monitoring
>>> of NVMe devices and fabrics paths, similar in spirit to tools such as
>>> top or iotop. The goal is to provide a continuously updating view of
>>> device and path health, enabling faster detection of link degradation,
>>> multipath imbalances, and transient failures.
>>>
>>> The series first adds the necessary building blocks for supporting a
>>> top-like dashboard. The initial patches extend the table APIs
>>> (including
>>> support for additional data types such as unsigned, long, float, and
>>> double) and introduce a generic dashboard framework. The final patch
>>> adds the nvme top command built on top of this framework.
>>>
>>> Future work:
>>> - Export NVMe statistics to external monitoring systems (e.g. Grafana).
>>> - Improve topology change detection in multipath configurations. The
>>> current implementation relies on kobject uevents for topology
>>> change,
>>> but namespace path add/delete events are not exported by the kernel
>>> since they are associated with hidden gendisk kobjects. This may
>>> require explicit uevent generation from the NVMe driver for
>>> namespace
>>> path changes.
>>> - Wire nvme top into an MCP pipeline and feed it to an LLM
>>
>> Nice, However I think that the traddr information is missing. Often
>> the network
>> has some routing issues for specific IP. This tool show this.
>
> This tool prints the traddr but NOT host_traddr. Did you mean we
> should print host_traddr?
> If yes, then I think that should be a fair ask.
I didn't see the traddr...
Also, ctrl+c is not existing which is annoying ;)
next prev parent reply other threads:[~2026-05-11 12:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:52 [PATCH 0/7] nvme-cli: add nvme top command for real-time monitoring Nilay Shroff
2026-04-30 10:52 ` [PATCH 1/7] nvme: add support for unsigned and long types in table_get_value_width() Nilay Shroff
2026-04-30 10:52 ` [PATCH 2/7] nvme: use table_get_value_width() in table_print_centered() Nilay Shroff
2026-04-30 10:52 ` [PATCH 3/7] nvme: add support for float and double types in table_print_XXX() Nilay Shroff
2026-04-30 10:52 ` [PATCH 4/7] nvme: allow table output to be directed to a FILE stream Nilay Shroff
2026-04-30 10:52 ` [PATCH 5/7] nvme: add sigaction for SIGWINCH Nilay Shroff
2026-04-30 10:52 ` [PATCH 6/7] nvme: add generic top-like dashboard framework Nilay Shroff
2026-04-30 10:52 ` [PATCH 7/7] nvme: add nvme top command Nilay Shroff
2026-05-03 17:40 ` [PATCH 0/7] nvme-cli: add nvme top command for real-time monitoring Daniel Wagner
2026-05-07 16:28 ` Daniel Wagner
2026-05-11 5:46 ` Nilay Shroff
2026-05-10 22:34 ` Sagi Grimberg
2026-05-11 11:59 ` Nilay Shroff
2026-05-11 12:54 ` Sagi Grimberg [this message]
2026-05-11 14:04 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ef5a04-8b34-479c-bc09-09af6cd104f5@grimberg.me \
--to=sagi@grimberg.me \
--cc=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox