From: Daniel Wagner <dwagner@suse.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, hare@suse.com, kbusch@kernel.org,
hch@lst.de, gjoyce@linux.ibm.com, wenxiong@linux.ibm.com
Subject: Re: [PATCH 0/7] nvme-cli: add nvme top command for real-time monitoring
Date: Sun, 3 May 2026 19:40:21 +0200 [thread overview]
Message-ID: <ce49c901-7879-468b-afe4-88cd2c3c3dec@flourine.local> (raw)
In-Reply-To: <20260430105234.1172446-1-nilay@linux.ibm.com>
On Thu, Apr 30, 2026 at 04:22:21PM +0530, Nilay Shroff wrote:
> As usual feedback, comments, and suggestions are welcome!
I gave it a quick test. Overall looks pretty good and useful. One thing
I noticed was that the table width jumped around when the bandwith was
not constant, e.g jumping between 0 and some value. But that is minor
thing. Let's discuss and collect some feedaback during LSFMM.
Cheers,
Daniel
next prev parent reply other threads:[~2026-05-03 17:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:52 [PATCH 0/7] nvme-cli: add nvme top command for real-time monitoring Nilay Shroff
2026-04-30 10:52 ` [PATCH 1/7] nvme: add support for unsigned and long types in table_get_value_width() Nilay Shroff
2026-04-30 10:52 ` [PATCH 2/7] nvme: use table_get_value_width() in table_print_centered() Nilay Shroff
2026-04-30 10:52 ` [PATCH 3/7] nvme: add support for float and double types in table_print_XXX() Nilay Shroff
2026-04-30 10:52 ` [PATCH 4/7] nvme: allow table output to be directed to a FILE stream Nilay Shroff
2026-04-30 10:52 ` [PATCH 5/7] nvme: add sigaction for SIGWINCH Nilay Shroff
2026-04-30 10:52 ` [PATCH 6/7] nvme: add generic top-like dashboard framework Nilay Shroff
2026-04-30 10:52 ` [PATCH 7/7] nvme: add nvme top command Nilay Shroff
2026-05-03 17:40 ` Daniel Wagner [this message]
2026-05-07 16:28 ` [PATCH 0/7] nvme-cli: add nvme top command for real-time monitoring Daniel Wagner
2026-05-11 5:46 ` Nilay Shroff
2026-05-10 22:34 ` Sagi Grimberg
2026-05-11 11:59 ` Nilay Shroff
2026-05-11 12:54 ` Sagi Grimberg
2026-05-11 14:04 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce49c901-7879-468b-afe4-88cd2c3c3dec@flourine.local \
--to=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox