From: axboe@kernel.dk (Jens Axboe)
Subject: [GIT PULL] nvme fixes for Linux 4.15
Date: Thu, 23 Nov 2017 21:54:33 -0700 [thread overview]
Message-ID: <514cf7e6-f651-112e-c8bb-e5ad837d4394@kernel.dk> (raw)
In-Reply-To: <20171123144438.wfs2fo64l6vwgfxj@infradead.org>
On 11/23/2017 07:44 AM, Christoph Hellwig wrote:
> Sagi Grimberg (3):
> nvme-fc: check if queue is ready in queue_rq
> nvme-loop: check if queue is ready in queue_rq
The nvme-loop part looks fine, but why is the nvme-fc part using:
enum nvme_fc_queue_flags {
NVME_FC_Q_CONNECTED = (1 << 0),
+ NVME_FC_Q_LIVE = (1 << 1),
};
for flags that are used with set_bit() and friends? That's just
misleading, should be 0, 1, etc, not a shift.
The rest looks pretty straight forward, but the above is an eye sore.
--
Jens Axboe
next prev parent reply other threads:[~2017-11-24 4:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 14:44 [GIT PULL] nvme fixes for Linux 4.15 Christoph Hellwig
2017-11-24 4:54 ` Jens Axboe [this message]
2017-11-24 5:04 ` Jens Axboe
2017-11-24 8:32 ` Christoph Hellwig
2017-11-24 17:15 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2017-11-29 16:16 Christoph Hellwig
2017-11-29 16:30 ` Jens Axboe
2018-01-05 17:15 Christoph Hellwig
2018-01-05 17:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514cf7e6-f651-112e-c8bb-e5ad837d4394@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox