* [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD).
@ 2014-05-28 12:58 Indraneel Mukherjee
2014-05-28 16:40 ` Vishal Verma
2014-05-28 20:40 ` J Freyensee
0 siblings, 2 replies; 3+ messages in thread
From: Indraneel Mukherjee @ 2014-05-28 12:58 UTC (permalink / raw)
diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
index da3b252..0d9805b 100644
--- a/drivers/block/nvme-scsi.c
+++ b/drivers/block/nvme-scsi.c
@@ -1014,8 +1014,8 @@ static int nvme_trans_log_info_exceptions(struct nvme_ns *ns,
c.common.opcode = nvme_admin_get_log_page;
c.common.nsid = cpu_to_le32(0xFFFFFFFF);
c.common.prp1 = cpu_to_le64(dma_addr);
- c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
- BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
+ c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
+ BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
res = nvme_submit_admin_cmd(dev, &c, NULL);
if (res != NVME_SC_SUCCESS) {
temp_c = LOG_TEMP_UNKNOWN;
@@ -1082,8 +1082,8 @@ static int nvme_trans_log_temperature(struct nvme_ns *ns, struct sg_io_hdr *hdr,
c.common.opcode = nvme_admin_get_log_page;
c.common.nsid = cpu_to_le32(0xFFFFFFFF);
c.common.prp1 = cpu_to_le64(dma_addr);
- c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
- BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
+ c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
+ BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
res = nvme_submit_admin_cmd(dev, &c, NULL);
if (res != NVME_SC_SUCCESS) {
temp_c_cur = LOG_TEMP_UNKNOWN;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD).
2014-05-28 12:58 [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD) Indraneel Mukherjee
@ 2014-05-28 16:40 ` Vishal Verma
2014-05-28 20:40 ` J Freyensee
1 sibling, 0 replies; 3+ messages in thread
From: Vishal Verma @ 2014-05-28 16:40 UTC (permalink / raw)
On Wed, 2014-05-28@18:28 +0530, Indraneel Mukherjee wrote:
> diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
> index da3b252..0d9805b 100644
> --- a/drivers/block/nvme-scsi.c
> +++ b/drivers/block/nvme-scsi.c
> @@ -1014,8 +1014,8 @@ static int nvme_trans_log_info_exceptions(struct nvme_ns *ns,
> c.common.opcode = nvme_admin_get_log_page;
> c.common.nsid = cpu_to_le32(0xFFFFFFFF);
> c.common.prp1 = cpu_to_le64(dma_addr);
> - c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
> - BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
> + c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
> + BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
Documentation/CodingStyle says both these changes should read ") - 1)"
instead of ")-1)" (spacing difference).
> res = nvme_submit_admin_cmd(dev, &c, NULL);
> if (res != NVME_SC_SUCCESS) {
> temp_c = LOG_TEMP_UNKNOWN;
> @@ -1082,8 +1082,8 @@ static int nvme_trans_log_temperature(struct nvme_ns *ns, struct sg_io_hdr *hdr,
> c.common.opcode = nvme_admin_get_log_page;
> c.common.nsid = cpu_to_le32(0xFFFFFFFF);
> c.common.prp1 = cpu_to_le64(dma_addr);
> - c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
> - BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
> + c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
> + BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
> res = nvme_submit_admin_cmd(dev, &c, NULL);
> if (res != NVME_SC_SUCCESS) {
> temp_c_cur = LOG_TEMP_UNKNOWN;
In principle, the patch is good, thanks for submitting this. I'd be
happy to ack this once you resend with the changes.
-Vishal
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD).
2014-05-28 12:58 [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD) Indraneel Mukherjee
2014-05-28 16:40 ` Vishal Verma
@ 2014-05-28 20:40 ` J Freyensee
1 sibling, 0 replies; 3+ messages in thread
From: J Freyensee @ 2014-05-28 20:40 UTC (permalink / raw)
On 05/28/2014 05:58 AM, Indraneel Mukherjee wrote:
>
Could there be an intro/description to this patch like there is for all
the other patches I've seen on this list, please (Keith's patch sent
yesterday could be an example)? Thanks!
> diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
> index da3b252..0d9805b 100644
> --- a/drivers/block/nvme-scsi.c
> +++ b/drivers/block/nvme-scsi.c
> @@ -1014,8 +1014,8 @@ static int nvme_trans_log_info_exceptions(struct nvme_ns *ns,
> c.common.opcode = nvme_admin_get_log_page;
> c.common.nsid = cpu_to_le32(0xFFFFFFFF);
> c.common.prp1 = cpu_to_le64(dma_addr);
> - c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
> - BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
> + c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
> + BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
> res = nvme_submit_admin_cmd(dev, &c, NULL);
> if (res != NVME_SC_SUCCESS) {
> temp_c = LOG_TEMP_UNKNOWN;
> @@ -1082,8 +1082,8 @@ static int nvme_trans_log_temperature(struct nvme_ns *ns, struct sg_io_hdr *hdr,
> c.common.opcode = nvme_admin_get_log_page;
> c.common.nsid = cpu_to_le32(0xFFFFFFFF);
> c.common.prp1 = cpu_to_le64(dma_addr);
> - c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
> - BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
> + c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
> + BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
> res = nvme_submit_admin_cmd(dev, &c, NULL);
> if (res != NVME_SC_SUCCESS) {
> temp_c_cur = LOG_TEMP_UNKNOWN;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-28 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28 12:58 [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD) Indraneel Mukherjee
2014-05-28 16:40 ` Vishal Verma
2014-05-28 20:40 ` J Freyensee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox