From: sbradshaw@micron.com (Sam Bradshaw)
Subject: [PATCH] NVMe: Remove remnants of cpu hotplug
Date: Thu, 4 Dec 2014 09:43:47 -0800 [thread overview]
Message-ID: <54809D53.4060404@micron.com> (raw)
This patch cleans up some code inherited from the cpu hotplug handling,
including correcting a bug where hctx->cpumask included non-schedulable
cpus (backtrace attached).
Signed-off-by: Selvan Mani <smani at micron.com>
Signed-off-by: Sam Bradshaw <sbradshaw at micron.com>
---
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index bcbdf83..57ed698 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -76,7 +76,6 @@ static LIST_HEAD(dev_list);
static struct task_struct *nvme_thread;
static struct workqueue_struct *nvme_workq;
static wait_queue_head_t nvme_kthread_wait;
-static struct notifier_block nvme_nb;
static void nvme_reset_failed_dev(struct work_struct *ws);
static int nvme_process_cq(struct nvme_queue *nvmeq);
@@ -1981,7 +1980,7 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
struct pci_dev *pdev = dev->pci_dev;
int result, i, vecs, nr_io_queues, size;
- nr_io_queues = num_possible_cpus();
+ nr_io_queues = num_online_cpus();
result = set_queue_count(dev, nr_io_queues);
if (result <= 0)
return result;
@@ -2878,7 +2877,6 @@ static int __init nvme_init(void)
static void __exit nvme_exit(void)
{
pci_unregister_driver(&nvme_driver);
- unregister_hotcpu_notifier(&nvme_nb);
unregister_blkdev(nvme_major, "nvme");
destroy_workqueue(nvme_workq);
BUG_ON(nvme_thread && !IS_ERR(nvme_thread));
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bt
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20141204/645d4d01/attachment-0001.ksh>
next reply other threads:[~2014-12-04 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 17:43 Sam Bradshaw [this message]
2014-12-04 17:57 ` [PATCH] NVMe: Remove remnants of cpu hotplug Jens Axboe
2014-12-04 21:54 ` Sam Bradshaw (sbradshaw)
2014-12-09 20:50 ` Sam Bradshaw (sbradshaw)
2014-12-09 20:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54809D53.4060404@micron.com \
--to=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox