From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] NVMe: Remove remnants of cpu hotplug
Date: Thu, 04 Dec 2014 10:57:05 -0700 [thread overview]
Message-ID: <5480A071.3080103@kernel.dk> (raw)
In-Reply-To: <54809D53.4060404@micron.com>
On 12/04/2014 10:43 AM, Sam Bradshaw wrote:
> This patch cleans up some code inherited from the cpu hotplug handling,
> including correcting a bug where hctx->cpumask included non-schedulable
> cpus (backtrace attached).
Getting rid of the notifier_block is definitely right, that should not
be there anymore.
I'm curious with the num_possible -> num_online change. This should be
handled by blk-mq, so no worries there. But how did it trigger the unset
CPU in the run mask? Ran into the same issue here on a different test
case, just curious if you looked into this.
--
Jens Axboe
next prev parent reply other threads:[~2014-12-04 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 17:43 [PATCH] NVMe: Remove remnants of cpu hotplug Sam Bradshaw
2014-12-04 17:57 ` Jens Axboe [this message]
2014-12-04 21:54 ` Sam Bradshaw (sbradshaw)
2014-12-09 20:50 ` Sam Bradshaw (sbradshaw)
2014-12-09 20:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5480A071.3080103@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox